Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp240420pxf; Wed, 10 Mar 2021 05:26:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWvVopphS4P4t+g30MaCgajBdB91pC5fQYKHVE3KBDWJe9HIpde1kfX0v3KotXR1DPoZqR X-Received: by 2002:a17:906:8904:: with SMTP id fr4mr3738720ejc.136.1615382792027; Wed, 10 Mar 2021 05:26:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615382792; cv=none; d=google.com; s=arc-20160816; b=FZWhBWX5VlNosvatMcsdubVAY0+tqoEeVCE8XVPKpU2ZK6N8KVKAivwAKjltVNi0YF LlQx5ZJG7QaFnbI2XJ6zSQr9afuMd6sB6Lka6t83Deav45ZyZPtIXjtn0ynam7AMXFpR 4qs9pBr5IrCPqjEv6Vyuv5w3pMCnmxei0/dEWIpSA0CMMYhgyHrOk5axv8IdPrng5noS 14y9Crt66IszkZ2dItq1qE6mgDis5cDGIQemfWSA9MSN0tv1Sv9ZucAIyJZKOGvngjfw cOtAkrB6cEKDKhY/r+FmyMCb+2Yg2iFF777e3KLMwJ2vZciNDzFuKAMJlUJrDq03a7LC 0vbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l8XmRgpuB3urro1hEaLx8G1ZvERxEm32XAXq1TP6OVE=; b=ZQPjTOe60MckZGV/WzmrTibDwXP64F0bNaTCLHfOkEA9vJk5PUMwCtsHZfCNhsn+LU WWaN1QpTOKYi2cowdq6N5zfoFz211GyWpD42ErZh+ye6j3YBgIAC7piNOeFGPWdkaQFx EGkddovlm7gwuD3R6RkMULdIKsLEM0WebFdQ5h3F1/iGzYWhxGoWtmWkcBu6bMl3iWqG MKufL03q9eLBWgjzaoLNCPURrXg2yuGPYIl5w+y8ml7ARHtj7I0bFDiqv/5wu1K1n/NR xxDOQfZ03HxqzkWhuQqx2FOOcGc66y3CbECEIJJUfoK5j12Z72RvPt7JC7tGh7jHjC/8 Z/Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rSyM8uCy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z23si9098765eju.427.2021.03.10.05.26.08; Wed, 10 Mar 2021 05:26:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rSyM8uCy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233122AbhCJNY4 (ORCPT + 99 others); Wed, 10 Mar 2021 08:24:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:45490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232786AbhCJNYQ (ORCPT ); Wed, 10 Mar 2021 08:24:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A939664FEF; Wed, 10 Mar 2021 13:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382656; bh=CHQOddw/0GSWFWKZ0kKaTQHM1P0fVm9W4Y1NyCtzEZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rSyM8uCyjO5L9WRuI72vz57nOCcRE+Kx1J9ZTLKv1aK1I8XqWipix5Uqej9KaspR4 gEw/pLioi5WFgNJcxji7Yj/yFf3Q4gQo4/k9kGilqGAibxh5tYlb/rc/VICryrKJCv Hv60qyAMkL+s1Zx5notgTuWtSPoB+FFK0VSC89UA= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Zolt=C3=A1n=20B=C3=B6sz=C3=B6rm=C3=A9nyi?= , Christoph Hellwig , Sudip Mukherjee Subject: [PATCH 5.11 12/36] nvme-pci: mark Kingston SKC2000 as not supporting the deepest power state Date: Wed, 10 Mar 2021 14:23:25 +0100 Message-Id: <20210310132320.907725709@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132320.510840709@linuxfoundation.org> References: <20210310132320.510840709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: "Zolt?n B?sz?rm?nyi" commit dc22c1c058b5c4fe967a20589e36f029ee42a706 upstream My 2TB SKC2000 showed the exact same symptoms that were provided in 538e4a8c57 ("nvme-pci: avoid the deepest sleep state on Kingston A2000 SSDs"), i.e. a complete NVME lockup that needed cold boot to get it back. According to some sources, the A2000 is simply a rebadged SKC2000 with a slightly optimized firmware. Adding the SKC2000 PCI ID to the quirk list with the same workaround as the A2000 made my laptop survive a 5 hours long Yocto bootstrap buildfest which reliably triggered the SSD lockup previously. Signed-off-by: Zoltán Böszörményi Signed-off-by: Christoph Hellwig Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3261,6 +3261,8 @@ static const struct pci_device_id nvme_i .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, { PCI_DEVICE(0x1d97, 0x2263), /* SPCC */ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, + { PCI_DEVICE(0x2646, 0x2262), /* KINGSTON SKC2000 NVMe SSD */ + .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, { PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */ .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),