Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp243133pxf; Wed, 10 Mar 2021 05:30:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJz33zdv3dCV5s/qv5wepLK18BCHb5Eh+ZEMF9LqM/eIveR2CdnasIGhsea8BM8ZR5zbCe+X X-Received: by 2002:a17:906:f896:: with SMTP id lg22mr3583139ejb.124.1615383034216; Wed, 10 Mar 2021 05:30:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615383034; cv=none; d=google.com; s=arc-20160816; b=hycuZpv8/AiWrSBuZnLjN21lrsOqLikb1Vc2dDe4ViJLiWc5BW1/lDESGiw0GIKTzw R/lemy+WhnI6w9Y+VeklWtXcEC7VZAYAxIIoqmt/JcwpJsEgcJO1UPCl65gdeIZKz9+L 5Xmszv/LbHNy3gqfMsQjhAiQ8JFCc797G+LQBRN+AgRR0cPVbYMX2TXIUpVKVSdr0/wQ 5sxb4ywQ91UvJHxEbnLG4zy2dZKapq49tZqJsGOaaLC7p206dgYqUNTteuoIR2/hynGK zBJqyeMH7IMGaFVOt4MXJmFzESqktpZsKUg3GMNj7BKrzCdAIOffFd0Ne7YIGUUXWyEm 0ipA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5EO0rkvBLcN9JE/NVlUeAYJ2yOnubc401icwx1Xdgwg=; b=KqIfr1GYirgoyf75y8iAYRmbdD55FzxF48yKS4tO9UtaEasvsQNpw9oDXLVQTADpWc VAo1KELnAD2xRHuocXV5DuoT2XvQFPyBXnqr9qlIdnV5PisHq2hv0BTtsf7ihIUoCUYW 5FnmBGMxe+C3v43opQKVVQuuqZnKtXXQ5csfFo696pA9frUwFetM+gICm08lnWYT+Y9s x+rRCxzxc4RMmclvoChTgb74jIFkWau4OoP8MnJY59a36Y0oQNUWFMqR2oYNLB61hgRW /5asxPoz/Y/vOM4UI7FZaST0Yp5Cbep7SsWjo5LwWofp7GH5Ro43m+0kyOroEGZiO8Rd lzpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="I/8jhFxh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv19si11086082ejc.109.2021.03.10.05.30.10; Wed, 10 Mar 2021 05:30:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="I/8jhFxh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233253AbhCJN3H (ORCPT + 99 others); Wed, 10 Mar 2021 08:29:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:47824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbhCJNZT (ORCPT ); Wed, 10 Mar 2021 08:25:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DA9365005; Wed, 10 Mar 2021 13:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382719; bh=HqEV5r+zl3NlOEjC4TRekPRUsF1UMxiw5G1WdwJJdM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I/8jhFxhU5iHcAlW0sNmL1yBh+J3e4zMKxMTHWVKSdVRFWTu2hlGjWGdKtXLDGd59 o9wNjobSChQC30Yps8fhEnmXGtNAdEGj/mML+Jvs/nbfHVnmfuYlExaK1djEU+D/ru ON13wu1qt3gRdH1eNUwL1acy7QrBzClFA5Oe+tqE= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Einwag , Christoph Hellwig , Keith Busch , Sasha Levin Subject: [PATCH 5.4 23/24] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST. Date: Wed, 10 Mar 2021 14:24:35 +0100 Message-Id: <20210310132321.257283951@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132320.550932445@linuxfoundation.org> References: <20210310132320.550932445@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Julian Einwag [ Upstream commit 5e112d3fb89703a4981ded60561b5647db3693bf ] The kernel fails to fully detect these SSDs, only the character devices are present: [ 10.785605] nvme nvme0: pci function 0000:04:00.0 [ 10.876787] nvme nvme1: pci function 0000:81:00.0 [ 13.198614] nvme nvme0: missing or invalid SUBNQN field. [ 13.198658] nvme nvme1: missing or invalid SUBNQN field. [ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds [ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds [ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues [ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues [ 13.239627] nvme nvme0: Identify Descriptors failed (8194) [ 13.246315] nvme nvme1: Identify Descriptors failed (8194) Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679 Signed-off-by: Julian Einwag Signed-off-by: Christoph Hellwig Reviewed-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index abc342db3b33..197a5cd253c3 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3164,7 +3164,8 @@ static const struct pci_device_id nvme_id_table[] = { { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */ .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, }, { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */ - .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, + .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY | + NVME_QUIRK_NO_NS_DESC_LIST, }, { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, { PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */ -- 2.30.1