Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp244364pxf; Wed, 10 Mar 2021 05:32:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJym51yW102cY3cKvchubI87dqIO7WtpO5w4IJ2tD6F3MT3Bdh3Q+/6pwOjuqjJuJpahc/Ss X-Received: by 2002:a17:907:3e8c:: with SMTP id hs12mr3696247ejc.105.1615383132630; Wed, 10 Mar 2021 05:32:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615383132; cv=none; d=google.com; s=arc-20160816; b=powqZEubZjyjsXdIrcTyxfcyvo30L1jULWDRuoTWvjteC+zhW/QUJe08eSRYmbK7E2 yCB44y4OK7hZLZab6DK4zWRWejKjoD134nI37lJsw6OtKhO2IvHC1m5Bz0fykEF+XDkt EK1RpzEonThxvapptX6P13q7YtsrvLYloKP7tLJoWhvqYtQmgmTpobKgjmuRsH9CjeSp moT3eWpAX1D6/nzZ2PS1hwFWye74z01+mqZRYcsOT9+7kZQcpMtenYg11j7Jg6KhU2H3 kYkUDmDzbJ8JA/DSA/FVCo+VJBqGi97V9PcHOmieyvLKyDFZIFk1I9J95X7b+IppmtkM NQgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EOKMJGkmMyqZZUL0toYWL1+HQXbcQ95uf5puZ/HTcNQ=; b=WfmKRj7BffsO1MKr9Amo9t21LB6fiXeqASNdSNhC9Lpi6VxISUs/lN+LaplY8Z+Fxg F6OAsAS6qNxuCdXSu8mWJy7Af2HCfrm508byQI2lnP2Y1XeM+Kb/YdwaLejgSfCAvVYt 7nd2zv7fL5cBhNw5rwkGoXqLB5zmyyciL54Ex/UZ4F76VtwgYpGqsve+m3mRFZElCyic voaB/YZ1BehS112jQoOhITxn1DmSp9JL3pHNZsJQoA/K9JNqN1F7n6yrsIK/8re0d4fn SimlZQzeH7kQeyBCTd3gYLZsbzeOz5B3+sejNnOmeSWp7/8kIxqYivK+8eDIPbAFcS8F jscw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5t9sE1p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s28si12305978ejm.721.2021.03.10.05.31.49; Wed, 10 Mar 2021 05:32:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5t9sE1p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234495AbhCJNat (ORCPT + 99 others); Wed, 10 Mar 2021 08:30:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:48260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233337AbhCJNZY (ORCPT ); Wed, 10 Mar 2021 08:25:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50B3164FFB; Wed, 10 Mar 2021 13:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382722; bh=m9ikSDjxS0/DHXNlAIK+OXpht2KBs3JnAENiSljRLZc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p5t9sE1pMCH1SCy/9R0JCymqVbLunU+L5ZSiwFSJGm/DHzW8XDdSmPyaRgER+XTtN JET6UHE36btbUPivj5loy8RMmMuA9fGh2fD74prYlnxeigJVCwP2Qp+vkJ6I2R+Qme fW9FxIiSqL7To65dCecev+/2gjc8OhfnVIoRh4wE= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Braha , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.19 17/39] RDMA/rxe: Fix missing kconfig dependency on CRYPTO Date: Wed, 10 Mar 2021 14:24:25 +0100 Message-Id: <20210310132320.268513994@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132319.708237392@linuxfoundation.org> References: <20210310132319.708237392@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Julian Braha [ Upstream commit 475f23b8c66d2892ad6acbf90ed757cafab13de7 ] When RDMA_RXE is enabled and CRYPTO is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for CRYPTO_CRC32 Depends on [n]: CRYPTO [=n] Selected by [y]: - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] This is because RDMA_RXE selects CRYPTO_CRC32, without depending on or selecting CRYPTO, despite that config option being subordinate to CRYPTO. Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible") Signed-off-by: Julian Braha Link: https://lore.kernel.org/r/21525878.NYvzQUHefP@ubuntu-mate-laptop Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig index 67ae960ab523..1fa19a77583e 100644 --- a/drivers/infiniband/sw/rxe/Kconfig +++ b/drivers/infiniband/sw/rxe/Kconfig @@ -3,6 +3,7 @@ config RDMA_RXE depends on INET && PCI && INFINIBAND depends on !64BIT || ARCH_DMA_ADDR_T_64BIT select NET_UDP_TUNNEL + select CRYPTO select CRYPTO_CRC32 select DMA_VIRT_OPS ---help--- -- 2.30.1