Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp244699pxf; Wed, 10 Mar 2021 05:32:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwR+/i8m49jVXoOGORGoVsmzcybH9N9ecfLiEqSFvTLX9hpnVRkf3/1SGYbUdU+TdeYTvIU X-Received: by 2002:a17:906:c005:: with SMTP id e5mr3696058ejz.270.1615383161300; Wed, 10 Mar 2021 05:32:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615383161; cv=none; d=google.com; s=arc-20160816; b=obngv1YEmF2tamcIYQoHJ3z+5bt+Z3HxeTStpww1D4FclkUXXlxQPYdVfyY+R2RHst MiivR8t0jeuFtD0S9vqhpSZW+9C8g/V+1zJ++8aAnHzm+zFjfIEbB7AtzXq1HQG6mUJV qz6hYSJ2DuNjwjH/c4c2mmyUSQXGk3DRaAW6P7CD38WXdn2y3RfXjaWYRPMq1rhkWr2f jVG9jvEQFawylK4y3u94YsPb9+mqk4Z2kyOgHh1p1VoLw6r6gsPxMDb8eH/hqAbrMRfj xc0t7570CD+Qq7YEpS+2K4jUyX8obgPcgpkgB4vuvtlFt6/DS3CZkU4d03WvkZCVGdIB bD2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2di51tMZUeBHr8czbp/2VcGgzrJAgd9WXMRsmmH2O/Q=; b=HmyMMrHwTR9wWSY/fOnqwcOb3qkuXIzOWhmYnoH9cHpg+27k521TihgfAN5iIG0ndY +NZRvDllC0BTPkWAhPSsNW4qkW8ovRVrqCFRKj4F9nCaty4krtqd3txU/kX4Q9bQcWZs 6ySiXOvK49os/f0bq273/+UHlwcahkOZX/8bST6ebsUAAk2pqJ4zMPD3K7nd73xlx+U/ HOk6a/jbqwIHgq69tVlOyN+fH3q39gB6twaq61GEmDdtw7bGaBfRLhtmu2mwlfe1PrpG o9ZVwOis0lEQG1Qu8SSEYY77CyD81mYjmJ1le66so13taIytnHipMkD+Va2TExBpdRSB grww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=leW80U4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x21si11974301eju.471.2021.03.10.05.32.16; Wed, 10 Mar 2021 05:32:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=leW80U4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234262AbhCJNb0 (ORCPT + 99 others); Wed, 10 Mar 2021 08:31:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:49782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233620AbhCJNZ7 (ORCPT ); Wed, 10 Mar 2021 08:25:59 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB9A864FF7; Wed, 10 Mar 2021 13:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382759; bh=w1603NGYE+4tJenpfNc6g2f/nZytrG0mz64X2KDz/ME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=leW80U4IpjQ/gv2IoGeHtPhmilXhYcCNABdM5EWDELM9FDjpn0VHfL6s8uJrV8HFV P9bQLQrCnti1NDoQwYn5gxEho0pWf6IdkOWK/HNDsijJmYduLPTelMTLQEvBiJHb3P ELKhE2SPjRn+E3sVMSA3sSCjsfnNxg49SBKjrmQo= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, AngeloGioacchino Del Regno , Jordan Crouse , Rob Clark , Sasha Levin Subject: [PATCH 4.19 38/39] drm/msm/a5xx: Remove overwriting A5XX_PC_DBG_ECO_CNTL register Date: Wed, 10 Mar 2021 14:24:46 +0100 Message-Id: <20210310132320.896041128@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132319.708237392@linuxfoundation.org> References: <20210310132319.708237392@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: AngeloGioacchino Del Regno [ Upstream commit 8f03c30cb814213e36032084a01f49a9e604a3e3 ] The PC_DBG_ECO_CNTL register on the Adreno A5xx family gets programmed to some different values on a per-model basis. At least, this is what we intend to do here; Unfortunately, though, this register is being overwritten with a static magic number, right after applying the GPU-specific configuration (including the GPU-specific quirks) and that is effectively nullifying the efforts. Let's remove the redundant and wrong write to the PC_DBG_ECO_CNTL register in order to retain the wanted configuration for the target GPU. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jordan Crouse Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index d29a58bd2f7a..776bbe9775e9 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -681,8 +681,6 @@ static int a5xx_hw_init(struct msm_gpu *gpu) if (adreno_gpu->info->quirks & ADRENO_QUIRK_TWO_PASS_USE_WFI) gpu_rmw(gpu, REG_A5XX_PC_DBG_ECO_CNTL, 0, (1 << 8)); - gpu_write(gpu, REG_A5XX_PC_DBG_ECO_CNTL, 0xc0200100); - /* Enable USE_RETENTION_FLOPS */ gpu_write(gpu, REG_A5XX_CP_CHICKEN_DBG, 0x02000000); -- 2.30.1