Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp245820pxf; Wed, 10 Mar 2021 05:34:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5fU9fqpq4+PX7IloICM0Mkt+zAW59tXBWTITTnLSV5kB1pD+8QxqHl5CPAPZZOKx98h2B X-Received: by 2002:a05:6402:5203:: with SMTP id s3mr3328368edd.79.1615383259158; Wed, 10 Mar 2021 05:34:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615383259; cv=none; d=google.com; s=arc-20160816; b=oWMBfEZcvH/FhUgWdF+fAMvr26aC3EvgTKM0j5gzM0JvQpIUmI7GBG7jyYLtjnK1Rh VrnCWaYTNHto6Ks0y9qKJkeMFOMs2986FohGHspgE+Zk/V6wDtC7w+T0NPjeYQBPV1Fn e2btlKFzOvVHRRpGXnMQ8GkZnCPXhDMnoBvhfWERf4r83SQiemZ1DQ9351mCOYKs2bJ4 7mlQajFYFyN9yqyF39F95F3Kh93XE1YeOHArOTH/8VrjJnuIHt6oLaHgWu33NLOnJ/Q4 /DaayQp0npFeZiq3+Nct/T6LvjM/Zsf7GacyYnUKYAxXt2EwKFjsNNjHAoyLXzYxspFY Lvrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=e5fjltDnBfAqnsxFSrinxxrmQWKIftTB/3C3cSfdklM=; b=ykqo940eO7s6o8WqukEoeb6RnAc/Oo5HV8jXD1+WUhM4MX5CtR+F5rGTkZCb6yOppH eVHF//kuSHnup30+QUl0MAcYJ0Ma0Po+OLnojmPJGF69eTpsJvZairHSh8eBM7oYBo7R ftFXsNQCvEMzZFO9NO3XMd/rHSVgrXOIBLRYycCkYB02Vl1vsYQ+xirdkwtdS30X4Qk4 QUPOubOKLbfIL8FRpAUHKNJZ30FbKEdbOSNnGH050VNaw6VUgc+izPE0oqsgAt3qM9b4 u4SRRigl4hag5ggaQFhRvHvlYecOxmqh4/NxYDHjWbPYLR2WUSbDfUxiRKeAFWkIyhuG OX4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="sf1/cdgd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si12005101edt.553.2021.03.10.05.33.56; Wed, 10 Mar 2021 05:34:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="sf1/cdgd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234791AbhCJNdD (ORCPT + 99 others); Wed, 10 Mar 2021 08:33:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234368AbhCJNcy (ORCPT ); Wed, 10 Mar 2021 08:32:54 -0500 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B61C061763 for ; Wed, 10 Mar 2021 05:32:54 -0800 (PST) Received: by mail-qk1-x72c.google.com with SMTP id z190so16710411qka.9 for ; Wed, 10 Mar 2021 05:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e5fjltDnBfAqnsxFSrinxxrmQWKIftTB/3C3cSfdklM=; b=sf1/cdgdKge7QLGVyzepeIFJl3wnkBfHoW5xh8d44j9SgupeyeQmGpzwPEAMzIyZ3p 9ctZKh+XfNw6DbaK+Zd/vifYJKBCGZ69QNByu7UoLm3cO0fcnpXUuCaknGkdVQlXBEVQ p7HZQIJ4ui1vuaB1BxCseZN0Xo9C8kmPmqhwNyPaUej08DKet4WfhtCgynv1twIA5ax0 853XsjbtmnNYIlQPSKYWJAxlYl789/0RY8jry3LiOx+ewpKOIkcr0bgn5f220d8cinaU ZL08lFu3hfkWQ+kW40a0yPlBOTn5qLulqyKBKh2llN2hGi2Vw96cEBG+8IDDLCqTPjLZ jDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e5fjltDnBfAqnsxFSrinxxrmQWKIftTB/3C3cSfdklM=; b=qGA2KWeyMjzpuQUcbmM4YykqNc78nH2OFl66vB5j/DlluFjpLaPVfMSV98/3T9Us3i 2uAZzdUL7wZ23qiq4ro3v9q+JgK81ALCAnCTebtbp83E53DLd/+I4h6SajZBXNbSffI8 Ibb/bYGc3JmYUdPdSnJMI6iG4CHvQbEYZ++FeDlue9PJD8m9308cu2zb4gaQZONX/5rG RVP4gWruq3uo1pYyIPw4JUcMzR3I/UABU/xcwarH3kUdsJYck8/uclMkeQd2LJdXZlk8 0hEEt1Zbz0nf+8JoX9KDNgZTXPdYQCrnkADPWsOB3KntmcZCkJFktT0pzikxw5tJ9mP4 f54Q== X-Gm-Message-State: AOAM531uiZ4kuBzY32xOktcMf8l668OcdRwq+ggJOvLAEgO3WHede5EW BS1Hr47dsLVN5D41+nNLMCxSEM/5b4M7Dw== X-Received: by 2002:a37:51c1:: with SMTP id f184mr2597720qkb.185.1615383173207; Wed, 10 Mar 2021 05:32:53 -0800 (PST) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id w13sm12170394qtv.37.2021.03.10.05.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 05:32:52 -0800 (PST) Subject: Re: [PATCH v10 0/8] Add support for ipq8064 tsens To: Daniel Lezcano , Ansuel Smith , Amit Kucheria Cc: Andy Gross , Bjorn Andersson , Zhang Rui , Rob Herring , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210217194011.22649-1-ansuelsmth@gmail.com> From: Thara Gopinath Message-ID: <44c7919c-0ed4-abba-21e0-226bb553aad3@linaro.org> Date: Wed, 10 Mar 2021 08:32:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/21 7:19 AM, Daniel Lezcano wrote: > > Hi Ansuel, > > On 17/02/2021 20:40, Ansuel Smith wrote: >> This patchset convert msm8960 to reg_filed, use int_common instead >> of a custom function and fix wrong tsens get_temp function for msm8960. >> Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs >> to be registered as a gcc child as the tsens regs on this platform are >> shared with the controller. >> This is based on work and code here >> https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage > > I don't have major concerns with the series except there is no comment > from the maintainer / reviewer of the sensor. > > Given it is based on Amit's work, I can assume they are correct. > > I added Thara in Cc hoping she has time to review the changes. If nobody > complains with the series, I'll merge them in the next days Hi Ansuel/Daniel, Just wanted to let you know that I have started looking into this and review this within next week or two. > > Thanks > > -- Daniel > > -- Warm Regards Thara