Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965221AbWJBSPY (ORCPT ); Mon, 2 Oct 2006 14:15:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965225AbWJBSPY (ORCPT ); Mon, 2 Oct 2006 14:15:24 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:53457 "EHLO mail.parisc-linux.org") by vger.kernel.org with ESMTP id S965221AbWJBSPX (ORCPT ); Mon, 2 Oct 2006 14:15:23 -0400 Date: Mon, 2 Oct 2006 12:15:22 -0600 From: Matthew Wilcox To: Frederik Deweerdt Cc: Arjan van de Ven , linux-scsi@vger.kernel.org, "Linux-Kernel," , "J.A. Magall??n" , Alan Cox , Andrew Morton , Jeff Garzik Subject: Re: [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Message-ID: <20061002181522.GL16272@parisc-linux.org> References: <1159550143.13029.36.camel@localhost.localdomain> <20060929235054.GB2020@slug> <1159573404.13029.96.camel@localhost.localdomain> <20060930140946.GA1195@slug> <451F049A.1010404@garzik.org> <20061001142807.GD16272@parisc-linux.org> <1159729523.2891.408.camel@laptopd505.fenrus.org> <20061001193616.GF16272@parisc-linux.org> <1159755141.2891.434.camel@laptopd505.fenrus.org> <20061002200048.GC3003@slug> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061002200048.GC3003@slug> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 54 On Mon, Oct 02, 2006 at 08:00:48PM +0000, Frederik Deweerdt wrote: > /** > + * pci_request_irq - Reserve an IRQ for a PCI device > + * @pdev: The PCI device whose irq is to be reserved > + * handler: The interrupt handler function, > + * pci_get_drvdata(pdev) shall be passed as an argument to that function I don't think you can (or should) do this. Move it to the body of the comment below. > + * @flags: The flags to be passed to request_irq() > + * @name: The name of the device to be associated with the irq > + * > + * Returns 0 on success, or a negative value on error. A warning > + * message is also printed on failure. > + */ > +int pci_request_irq(struct pci_dev *pdev, > + irqreturn_t (*handler)(int, void *, struct pt_regs *), > + unsigned long flags, const char *name) > +{ > + int rc; > + const char *actual_name = name; > + > + rc = is_irq_valid(pdev->irq); > + if (!rc) { > + dev_printk(KERN_ERR, &pdev->dev, "invalid irq #%d\n", pdev->irq); > + return -EINVAL; > + } Why is that more readable than if (!is_irq_valid(pdev->irq)) { dev_err(&pdev->dev, "invalid irq #%d\n", pdev->irq); return -EINVAL; } > + if (!actual_name) > + actual_name = pci_name(pdev); > + > + return request_irq(pdev->irq, handler, flags | IRQF_SHARED, > + actual_name, pci_get_drvdata(pdev)); The driver name is a far more common usage than the pci_name. return request_irq(pdev->irq, handler, flags | IRQF_SHARED, name ? name : pdev->driver->name, pci_get_drvdata(pdev)); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/