Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp280617pxf; Wed, 10 Mar 2021 06:21:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYRemwwq0/mEGQWUOpRSoLAliKR4wyFp650+mJ9irXU1s6GHZhlsic7eZVnPnAtg0yxj16 X-Received: by 2002:a50:ec81:: with SMTP id e1mr3544077edr.0.1615386099510; Wed, 10 Mar 2021 06:21:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615386099; cv=none; d=google.com; s=arc-20160816; b=vJ+M+0zruEMl7dErWDKq6Zx3d+voJpXezDEU4FHUcIwbe9955+tAl+FJku7QnCu0Vx Iqy5ogofQvvn4zIhCk4lIS2N+gDQSdW0U5CQE4X7NIz45ghtaf527AHkdoZTIZfCzsy7 gHzdSw1X+LvNA7nfHtsLddYTX2BDF9NfC9tmVRN40yZHvay44xOOaDlXAQksZfrsnOzo Xmy/RR4GGSJbE4imQymk2jSf4896Ogyf271kbsWh8bIx6jHn9ckocI1G5mDaC2W9LKTm gs6Fgw0THbArKMxcGRUilVQgX94nwJyMtjGOn/GOzQ/tUCAK1gxUr1j9DTYnQ/28/cqh RuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=//Y60BMpOFSBS4gIQV7QmVdL1NFNEwj66V4nPJtQgrk=; b=aJXPVm2MEBmBgHZzfnqwwYgkHVPTyqod5MbsgR/3HsYJ0ufeOfvAdgME4i52ojzL+2 5pr8N9jChekH9y3tqLCym7Kp9WYHu4YU7HrJLAfauNWtI4m898FJ67KVtIywdOJ7hz7E S2/IdZqDDyVkTAMwIhKqqwWamzlMfpvDp62yfP/3bazHymGdjI/f2MRXMUNFWdJCWzbl Qe+0lr1poYxFwt1aHfX8UgviZUZA1Eurs6XpvxKGqikYY8iSjMeN++CMB5XV4w3JqVdO iDp2o2fKzGRIDVeU7E3zihvrxfpxrd15ucwnY1J854dZRZM7wDUcWZ5lO1xlyBglwjzq Sazg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mail.ustc.edu.cn header.s=dkim header.b=Wtgf8I0j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mail.ustc.edu.cn Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ml22si10779475ejb.629.2021.03.10.06.21.08; Wed, 10 Mar 2021 06:21:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mail.ustc.edu.cn header.s=dkim header.b=Wtgf8I0j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mail.ustc.edu.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232990AbhCJOSN (ORCPT + 99 others); Wed, 10 Mar 2021 09:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232786AbhCJORu (ORCPT ); Wed, 10 Mar 2021 09:17:50 -0500 Received: from ustc.edu.cn (email6.ustc.edu.cn [IPv6:2001:da8:d800::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A5ED1C061761 for ; Wed, 10 Mar 2021 06:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ustc.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date: Message-Id:MIME-Version:Content-Transfer-Encoding; bh=//Y60BMpOF SBS4gIQV7QmVdL1NFNEwj66V4nPJtQgrk=; b=Wtgf8I0jmwyOasQODR/3JhjWjn SKY4zG7PRZ+dkx2V6BUnKi5cfzxb/PWJTrMJVGruhPlgfcNc+6pj7EVWcxm+rvJL 6acrPPpqQsagHbRFc4Tl2mK7AGmwjwvnz0SsJvEdxwoNDjYeHOfGp6gbpU2Vjcxl 4Uvl2upVQEv0GRgBQ= Received: from ubuntu.localdomain (unknown [114.214.224.243]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygAXBGEE1UhgCM0EAA--.2042S4; Wed, 10 Mar 2021 22:17:40 +0800 (CST) From: Lv Yunlong To: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, Lv Yunlong Subject: [PATCH v2] greybus/operation: Drop reference when message has been sent Date: Wed, 10 Mar 2021 06:17:36 -0800 Message-Id: <20210310141736.3459-1-lyl2019@mail.ustc.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: LkAmygAXBGEE1UhgCM0EAA--.2042S4 X-Coremail-Antispam: 1UD129KBjvdXoW7XryftrW8Cr1rAr18tw48tFb_yoWfCFc_u3 W8trsxAF4kJrs8Kasruw13ZrySyr4v9r18ur1ft39xA342vr1DJrWDWr4kWrWUGry8Xrnx Aa4DJryUXr1xujkaLaAFLSUrUUUUbb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4xFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2vYz4IE04k24VAvwVAKI4IrM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAG YxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUlQ6LUUU UU= X-CM-SenderInfo: ho1ojiyrz6zt1loo32lwfovvfxof0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In gb_operation_response_send, get an extra reference before gb_message_send() with this comment "/* Reference will be dropped when message has been sent. */". Therefore, we should drop the got reference not only in the error branch, but also in the complete branch. Signed-off-by: Lv Yunlong --- drivers/greybus/operation.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c index 8459e9bc0749..500b3fe53a04 100644 --- a/drivers/greybus/operation.c +++ b/drivers/greybus/operation.c @@ -855,6 +855,10 @@ static int gb_operation_response_send(struct gb_operation *operation, if (ret) goto err_put_active; + /*Drop reference after message send completes. */ + gb_operation_put_active(operation); + gb_operation_put(operation); + return 0; err_put_active: -- 2.25.1