Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [syzbot] possible deadlock in io_sq_thread_finish
To:     Pavel Begunkov <asml.silence@gmail.com>,
        Hillf Danton <hdanton@sina.com>,
        syzbot <syzbot+ac39856cb1b332dbbdda@syzkaller.appspotmail.com>
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
References: <5112d102-d849-c640-868f-ee820163d02e@kernel.dk>
 <20210310041025.2438-1-hdanton@sina.com>
 <b8e8a0f8-12fa-5dc4-6bcc-a274a8b2adec@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <d20d356f-6086-f3cd-eca6-f8bd16365686@kernel.dk>
Date:   Wed, 10 Mar 2021 07:26:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <b8e8a0f8-12fa-5dc4-6bcc-a274a8b2adec@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/10/21 6:40 AM, Pavel Begunkov wrote:
> On 10/03/2021 04:10, Hillf Danton wrote:> 
>> Fix 05ff6c4a0e07 ("io_uring: SQPOLL parking fixes") in the current tree
>> by removing the extra set of IO_SQ_THREAD_SHOULD_STOP in response to
>> the arrival of urgent signal because it misleads io_sq_thread_stop(),
>> though a followup cleanup should go there.
> 
> That's actually reasonable, just like
> 8bff1bf8abeda ("io_uring: fix io_sq_offload_create error handling")
> 
> Are you going to send a patch?

Agree - Hillf, do you mind if I just fold this one in?

-- 
Jens Axboe