Received: by 2002:a05:6520:3645:b029:c0:f950:43e0 with SMTP id l5csp542505lki; Wed, 10 Mar 2021 07:28:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLodSI0d6C9yMiyxRI/J9aa4NUpdM3wOC6ZoQTKroqIlLqW9J77iiiwfwXu7z0kRISbSVE X-Received: by 2002:aa7:c398:: with SMTP id k24mr3910310edq.61.1615390088472; Wed, 10 Mar 2021 07:28:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615390088; cv=none; d=google.com; s=arc-20160816; b=WeD7Ne3XuLOpvazp01HS4Gdk5L3ImisRs8L9Pmr4lnKrfXQeUtMwkEjBNPm5mBErvc ePOGCmVPGo4TECYfUfRDtMdhup9wDWQCNnimdQFgvmA8ZTijh0nDSgV6EcNQTYu6mA3G QZI/XOV4ematSYzUCB+3NCGvXQSFyFUWyUm0lpLiQdj3e8hZUckrBL5lLQvi2s57UmLY ZVbLlHb+dyL+JxoklH0p5Ct7gf75iY11Zmxd/d+jGZtwXgKoiy8c/BRbmJW2iBHfezbO iHauq+CmBSUmLAXibA4rRRChoZoj4PjUxb/5iQ5HL6iQ6f75ZtF5XFWU7nUEqAwVrrgQ wT8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=0j+bHu3iXH8HjnjVM83afjyL/KXBL2oPI3bv48YdxXw=; b=vAISzfbumuodXxb03/vSL1aD96EtJOtXhEjRcIEjhvYURJqFsjYFSBIU0+W+5ESUrX aKuCADC6UbuuNV14aqC9Aq+PR7qz/5VWBHNS2avs/MW0zfjJo5hsn6/7ClEQhys9Yedn hpJC4EGw1ekQh0zu9XVo9J9dbAnqLvexo+FXliCaVcMgCLI0qLKTTgoABBG3NR2wtO4+ 80AS3ELaM/LmpeiPkKlWmn6S59I68fNCWGMc0uel/hYDzpE9T06pvNLiGX2G6oH4Zo+z AHL2wKgbVI/p3rxtPZoeoGF3RVcIq+i85EKSuQCPfQ6SxpyXS5F9nj0ThWxibM6klgY/ +lIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZQiRmhgR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si11619028edu.225.2021.03.10.07.27.44; Wed, 10 Mar 2021 07:28:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZQiRmhgR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbhCJP0s (ORCPT + 99 others); Wed, 10 Mar 2021 10:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbhCJP0W (ORCPT ); Wed, 10 Mar 2021 10:26:22 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1AAC061761 for ; Wed, 10 Mar 2021 07:26:10 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id p10so15882260ils.9 for ; Wed, 10 Mar 2021 07:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0j+bHu3iXH8HjnjVM83afjyL/KXBL2oPI3bv48YdxXw=; b=ZQiRmhgRiDJM1ExEBOq9yi4Apm/6NTwVfFVloNORnQ2cRtlhBji3yuxdvhH5TxZYYf nlbz12Ei6H6RjF9X5prZwHq86Jy3vrJxnLP2GweM4GLocgAJGFJwaI1ic47udFXS0NqP wHxm0UojBmGq8cA73wvCz3HTnI4972hf0pjuPprCeIyF9/Z6vt7kb+TglvIc+x72TJuH Ihjz8Ud+/v/zOZaDcIfGLj0heCW8t9l0sMcb79dgaiobwOdwNtLDui70g5EB8DK7aiwD qDUht7Opqwv7chiRUL2mmGw8vyxqOgjxGkP1dnyzZGgBcc55MqFE20RB5EASQb64kKNU d3/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0j+bHu3iXH8HjnjVM83afjyL/KXBL2oPI3bv48YdxXw=; b=qeqaqX6WCYBpsDJ0DmImKYmAK/3GUvb6NmAn1QCTR8VJy7plHAKQz9osrMmIhMKOzm xzFEj6ozKQ5SB2LTHPK6dSVdtteT4ROYpN08DKUnTHaLI/kvlUPeQW3R6ygzm/rQfOJt dzpQn3WAllwIVS5EaJOCV2j6Ya6s47LoEiRsPrQ9OSyydFLeyPFmC58lDR7Zdn1gIWft d8YiKeKlw/X6+mYwlNucPijxADL84coWiHnHdzO+7AniRa2o+WX1WFsGaNyGUwJHlcDW TnCg6Jwu0tmBRJXHjJEgE0m/1Wki+qpjh4Luxq3Xt0N0EJzd1wHwi9JcgNBcYmfDqhQ+ r0iw== X-Gm-Message-State: AOAM530yglCKCGA0w03eEVOAb4+MOJQhZCIok060Q/urXhV3bMNuuAs9 H+++qDF7CATj9nSR+soQLcuiRkBPZhHC0Q== X-Received: by 2002:a05:6e02:18c9:: with SMTP id s9mr3075571ilu.265.1615389970003; Wed, 10 Mar 2021 07:26:10 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id n7sm8971398ili.79.2021.03.10.07.26.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 07:26:09 -0800 (PST) Subject: Re: [PATCH v2] block: rsxx: fix error return code of rsxx_pci_probe() To: Jia-Ju Bai , josh.h.morris@us.ibm.com, pjk1939@linux.ibm.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210310033017.4023-1-baijiaju1990@gmail.com> From: Jens Axboe Message-ID: <746df289-a8d9-9b73-d37d-cffe44b36bc9@kernel.dk> Date: Wed, 10 Mar 2021 08:26:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210310033017.4023-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/9/21 8:30 PM, Jia-Ju Bai wrote: > When create_singlethread_workqueue returns NULL to card->event_wq, no > error return code of rsxx_pci_probe() is assigned. > > To fix this bug, st is assigned with -ENOMEM in this case. Thanks, this looks much better. Applied. -- Jens Axboe