Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp358099pxf; Wed, 10 Mar 2021 07:47:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJymd+S4xjoZCgSY7i6ENE7WA6EKvbA664qwIHZsdK6O4WR1gOAufnd9UCCwCUOB6gZP4q4i X-Received: by 2002:a17:906:cb11:: with SMTP id lk17mr4181631ejb.405.1615391238460; Wed, 10 Mar 2021 07:47:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615391238; cv=none; d=google.com; s=arc-20160816; b=TQ7rPEeIcER4VtF6/svduGU2ibXp+ca+vfiqvgtT7Ko1YmRpE0cNjvR+Oa+zT40F2Z o56almmCI7iEXRaLlY7/1V2moEgb7AMceupDGH8TcL8byucQofJkT/+FK+ydXERnujNA xs3nfe4lkpjMiCv3GooXXxlQhqBEPR/AeJtFZuTeOree1CTkJXBJHeYEjKbBRYeQajqv GFo4AVEKh2iNEHPhJ07gerLAmsSQpFFIryAvGRCGcwzWuXDZ+HmTBMDGZMq5R5AhEVgh nTMifDPSBlB8YekzACjC4JQlfiMegc1UCrvvrmVvl/StKpcLH4CyRK87HWeOyqxGGbWi wPTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=2dWXgHdI36n8GQU9izVHjhjllN7NRuBcGIyGvWvVoIU=; b=jcOe7MDTYEHtML0uzptgHY01fnvZdgB6YKzcSUuVMg/QpmWcH0p5NzxsI6z91BdTnJ +CQXmeqLXJoalQyI52Dzt0cRSwDDeXUYEq7XppnpMGZs8fqvpnscBnDpcgAxpLTFWrgy rb6pzikPtXQRNYS2ZyB6K7QBZ4VWQ68PKqpg07FeZoB8kqiNs43zcq6m5GUDTSJcil6a uaOT7fytpNtW6fh9pGQMuy+d7v/+LW3zTioJ15h5N5LcNzINjXUlI9TjW04QocQqqxLH 9DeFmQnEt8BzKPNb5YvYA2nhkdGqrgl5qymMeEnoB9upSkBgVxx4mOkKBcaZj6gR0Ye/ vO9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a22si12000297ejp.696.2021.03.10.07.46.55; Wed, 10 Mar 2021 07:47:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbhCJPod (ORCPT + 99 others); Wed, 10 Mar 2021 10:44:33 -0500 Received: from mga09.intel.com ([134.134.136.24]:25407 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhCJPoK (ORCPT ); Wed, 10 Mar 2021 10:44:10 -0500 IronPort-SDR: oSoGSbA+W96+8s8B542pLSOlE7VsY2I1zz73HV7b2M+Q8iY/5j6umpvW+pI+ioUoGMKJk/aoQO 7dZkqo+4mxjg== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="188589386" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="188589386" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 07:44:10 -0800 IronPort-SDR: qQdbsx34tWrJf+GmQW+EKuGyeK/eQQYhdUGeCwXB+UxTZeY7fC0J3xMO6Ff8cfkpnszZbGYf04 TQ4s6vwjFdAw== X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="403721850" Received: from huiyingw-mobl.amr.corp.intel.com (HELO [10.212.214.84]) ([10.212.214.84]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 07:44:08 -0800 Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present To: Mark Brown Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , linux-tegra@vger.kernel.org, Jon Hunter , Bard liao References: <20210303115526.419458-1-jonathanh@nvidia.com> <91480f92-a3f5-e71f-acdc-ea74488ab0a1@linux.intel.com> <20210310133534.GD4746@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> Date: Wed, 10 Mar 2021 09:44:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210310133534.GD4746@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/21 7:35 AM, Mark Brown wrote: > On Tue, Mar 09, 2021 at 01:41:45PM -0600, Pierre-Louis Bossart wrote: > >> The problem is that the cards are platform devices created by the parent >> (which itself may be a PCI or ACPI device) and have nothing to do with ACPI. > >> Could we flip the logic and instead explicitly detect OF devices? That >> restores functionality for us. > > Just change it to a system level check for ACPI, checking for OF would > leave problems for board files or any other alternative firmware > interfaces. did you mean if (!IS_ENABLED(CONFIG_ACPI)) ?