Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] kunit: fix checkpatch warning
To:     Lucas Stankus <lucas.p.stankus@gmail.com>,
        Brendan Higgins <brendanhiggins@google.com>
Cc:     "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20210303020350.4sahuojkqnkcxquf@smtp.gmail.com>
 <CAFd5g47rjt7i7JXWsYarqX_dShHiqSg8StKb7KCqOye3=eyZDg@mail.gmail.com>
 <20210304043554.jysk6qms4h4hue4i@smtp.gmail.com>
 <d9f1007a-8de4-45e4-b662-846054d50390@linuxfoundation.org>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <4cef7239-1fef-951a-6b99-07c8c973c091@linuxfoundation.org>
Date:   Wed, 10 Mar 2021 08:54:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <d9f1007a-8de4-45e4-b662-846054d50390@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/21 4:12 PM, Shuah Khan wrote:
> On 3/3/21 9:35 PM, Lucas Stankus wrote:
>> On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote:
>>> Did you change anything other than fixing the Signed-off-by that Shuah
>>> requested?
>>
>> No, I only fixed the Signed-off-by warning.
>>
>>> Generally when you make a small change after receiving a Reviewed-by
>>> (especially one so small as here), you are supposed to include the
>>> Reviewed-by with the other git commit message footers directly below
>>> the "Signed-off-by". Please remember to do so in the future.
>>>
>>> Also, when you make a change to a patch and send out a subsequent
>>> revision, it is best practice to make note explaining the changes you
>>> made since the last revision in the "comment section" [1] of the
>>> git-diff, right after the three dashes and before the change log as
>>> you can see in this example [2] (note that everything after
>>> "Signed-off-by: David Gow <davidgow@google.com>\n ---" and before
>>> "tools/testing/kunit/configs/broken_on_uml.config | 2 ++" is discarded
>>> by git am).
>>
>> Sorry for the incovenience regarding best practices, I'll keep that
>> noted for further contributions.
>>
> 

Sorry I should have asked you about this. I like to see what is being
fixed in the subject line.

Can you update the subject line. The current one doesn't say anything
about the nature of the fix.

Also please run the checkpatch script on your patches. This tool useful
and can offer you tips on improving your commit log as well as code.

thanks,
-- Shuah