Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp416286pxf; Wed, 10 Mar 2021 08:45:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyicvgjb7LBrFGRVI6K31wwKdIRSUi7PIAFro5rrRDcC3eTYErFoMOpouu4GXvMeCEC+2ub X-Received: by 2002:a17:906:94ca:: with SMTP id d10mr4572184ejy.107.1615394725366; Wed, 10 Mar 2021 08:45:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615394725; cv=none; d=google.com; s=arc-20160816; b=NrWFBtK0p9CpCc14K/u1feGH+5ehlN2aHykE6CzZ36GiupArnbwofRYFcB8iW/mz3h 2ygkieM+rT0rFAONnaApOsaO1q/HYzDBuX0fFqn6KLPlFc+BjQZodHwG+I3dReNBB+At pido6gW2cZZFqENhT3eipxV7WUtmzyNmT/ZH3vjf3mX5xTFIOrgoJcmFfT8yKPMv84sP 5pGWBzaSlov/9lLs7Du758Sh1m3PzNoEUeek60nchvDLxt/4A/bk7gZDPoZBC1RQPziY cGTeCzjG+KX7yKGEkg9CzGbbk1QbgRx9VydFLjT0iX0Tqnp4eHA/rf0c8JBd6V6YyoPo cXWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=coNqvcm3/4czTcRlmGYW2p5jpbpLRNev/do/BWjjx2o=; b=q6fsJrdRfJzLV6SlhHU83oDx0IQ1ZpNaOYM/QUHnyxMVtj+BjVR3kXymqHW6Re5yVO qsxdQC1BgTyMm9+xuvJ/xLotrb5exuiQKU1ETGDLvx3phbLrjw6refdLPfIM4LM7/z1r 01wMJyU2ulCppzXgpGyDEEsE8Z+6HyDtCJbd6bePkmvRGQFpG3yfGmigL7cYlO8uNDl7 RaPOSVZRvBdmT4inOwJtT5TgvpowSzl1UTgJv57OGaKpvJNU9+SEvVJLYDb5QCodWqnE 9i2CK2pov186ALby9ZJM4htLK2Ea2lDfPQjNFjQE1y/+ImpC0nvrbQKRZg2ocxXSa+gJ DqPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si2209531ejk.355.2021.03.10.08.45.01; Wed, 10 Mar 2021 08:45:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231625AbhCJQlb (ORCPT + 99 others); Wed, 10 Mar 2021 11:41:31 -0500 Received: from mga02.intel.com ([134.134.136.20]:46597 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231790AbhCJQl0 (ORCPT ); Wed, 10 Mar 2021 11:41:26 -0500 IronPort-SDR: VThSInN9ZKeyZjjzpHUgKsQlo4QDu9NRljxJTdE9Af67rR9dW1LZRof+7DeN9vmDx3IBwkBjdP 44NBn4gJ8NQw== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="175612703" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="175612703" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:41:23 -0800 IronPort-SDR: YYDjhh1OA5FA/uN50/iTRjQ0hrwf4lSd5EzYDJrUKp2IotZ73mJSacsS+5eHu3txj+eR013M9t BFj6NdzrLPcg== X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="403742860" Received: from huiyingw-mobl.amr.corp.intel.com (HELO [10.212.214.84]) ([10.212.214.84]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:41:21 -0800 Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present To: Takashi Iwai , Mark Brown Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , linux-tegra@vger.kernel.org, Jon Hunter , Bard liao References: <20210303115526.419458-1-jonathanh@nvidia.com> <91480f92-a3f5-e71f-acdc-ea74488ab0a1@linux.intel.com> <20210310133534.GD4746@sirena.org.uk> <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> <20210310161814.GA28564@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <9b073d01-f2fe-a99b-e53c-4a0b3f95ca05@linux.intel.com> Date: Wed, 10 Mar 2021 10:41:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/21 10:37 AM, Takashi Iwai wrote: > On Wed, 10 Mar 2021 17:18:14 +0100, > Mark Brown wrote: >> >> On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: >>> On 3/10/21 7:35 AM, Mark Brown wrote: >> >>>> Just change it to a system level check for ACPI, checking for OF would >>>> leave problems for board files or any other alternative firmware >>>> interfaces. >> >>> did you mean if (!IS_ENABLED(CONFIG_ACPI)) ? >> >> Is there a runtime check? > > Well, basically both DMI and ACPI are completely different things, so > I don't think it's right to check the availability of ACPI as a signal > of the availability of DMI. would this work? if (!IS_ENABLED(CONFIG_DMI)) return 0;