Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp421773pxf; Wed, 10 Mar 2021 08:51:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJziyqEeXgmrcFWYf7BJqN5HfnmOp1wiWTkMdscptunRekZZUUxnkOX25YAQk2NdirwVt41q X-Received: by 2002:a05:6402:180b:: with SMTP id g11mr4282255edy.195.1615395080311; Wed, 10 Mar 2021 08:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615395080; cv=none; d=google.com; s=arc-20160816; b=bWxZEWXAf4abBaKoyasahlzELvEJ2y2OM6s6lCmwG+DdZdneIm/BRHSPyH0bDXiILG 1tWIYkmJXvaf44e8MZdGpuxX8mCT9E9cg3NwrrGABDPBlxF5qHtTvdf7EcRCJ3aMaAem xwKE4TQ+xQdk+JvinmUBmdX7xcsGcWa85d6GNnEP04cIAleI8+1SwQLqgbvNiEFm5YPf +bGjIlSwHX/in1H635RaN732QLRlgfqvfp2czMK0D8Zb3TWGuml5va/1IqSbBYO8OFUf Yh/SObzKdPe5uaGF3eh5fqZ1HFQ8R5t3Ccos5Nqi1MVfpz/7PeIvZoiWvRdpr1+xrbXf 0UIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ugCEZrWf5A4XgpviDL5fP9EvSXRKP5irZWyEoItU4d4=; b=iTgtJf+5AnncD7mKqaL/MMNXTyZZCqhyuHxAUoSf+Z3vy6483F7nUmUVzkvN/IKrR7 /1MktlchFGzAhpzaw/5SxtrAhYljT6BHLYP/2HnvAgBoUDTCaFEo7xtjia66WNQLN0X5 ht+S/+hNBohQjE0M7JOL3sYgnaGrgGzD04X1mZkz5hwMXoMFur4ifg1+uULttBZAhWbz g8pG1MKLFUojZNXsyYleyQI6adO6UboDGRnZ7Axcu2GtPvM+Flgcs7d9iQmVQ6ZzWI2+ L9QE4Id2eHF1OxQ6LwDT+vT+v+01TafbRH5c+X9+TW5SUanr5KFBnjlqlJR5ssbsYcim sI3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si1318497ejf.96.2021.03.10.08.50.58; Wed, 10 Mar 2021 08:51:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhCJQuC (ORCPT + 99 others); Wed, 10 Mar 2021 11:50:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:40436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231263AbhCJQto (ORCPT ); Wed, 10 Mar 2021 11:49:44 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82DC264F58; Wed, 10 Mar 2021 16:49:43 +0000 (UTC) Date: Wed, 10 Mar 2021 11:49:42 -0500 From: Steven Rostedt To: Tony Lu Cc: davem@davemloft.net, mingo@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: add net namespace inode for all net_dev events Message-ID: <20210310114942.3ffb5e1f@gandalf.local.home> In-Reply-To: References: <20210309044349.6605-1-tonylu@linux.alibaba.com> <20210309124011.709c6cd3@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Mar 2021 17:03:40 +0800 Tony Lu wrote: > On Tue, Mar 09, 2021 at 12:40:11PM -0500, Steven Rostedt wrote: > > The above shows 10 bytes wasted for this event. > > > > I use pahole to read vmlinux.o directly with defconfig and > CONFIG_DEBUG_INFO enabled, the result shows 22 structs prefixed with > trace_event_raw_ that have at least one hole. > > > pahole shows there are 5 holes with 10 bytes in net_dev_start_xmit event. > Oh, an I'm glad that my analysis matched with pahole ;-) -- Steve