Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp467652pxf; Wed, 10 Mar 2021 09:46:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxWdDAHBG1AOgCcfEuE9SgH+pQ+0xsR4EdaNb3DMGsYu6JHbfnk+wfa+1k9eHhkl8+MrKS X-Received: by 2002:aa7:d316:: with SMTP id p22mr4473711edq.107.1615398411728; Wed, 10 Mar 2021 09:46:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615398411; cv=none; d=google.com; s=arc-20160816; b=CYH+gqpdQsp+RG76isTB2Yyk9Htp36eec0mhLPXzHpaXaN2fHVMQTdFa6CJpfmImzJ Pp8JXh9yeZZxV9ZyIpDlwoWUq+ofgyh4hvmQM5Xt5/P4gI+jgM1noo5cbX/v10J0+Oax vScinxr45kXY/JSY2miAefuvYdpT4O8BnlAwNvbL67av/1c4VrxYEeXArMk5CHtq0zcr 6ud/yfjC/X6EhnbAd9Xs3kguDye5YlfQSg0L8zmKLaNGbTt/svUi6n+oCfxGnEWvnp2D 25iuAUvGBdbnji6navVViNfNNhebkbc3edwmcIag4f3xk9AN5F9+5pEH8BsmVAa3gsYF 1Tyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Mn8sY8sJqOTDe7oikzYLEpWDu7TaX1hz5Zzib5aMyfk=; b=QPHKYKVkoeG+ltM1BMIj+xxzgJSb4vOo+FbFq9FBDe2SUqh/4ya3KV0TWtiKONa6X3 D8blAhev9iyI1jozorh2+8tXz2y8bkCtS5g0Q3NkpGYgy4r5ofdYYatodvGRUTim3pEE STC50EvyRIgodgtd4/N3oIyHPWLy5pTX9NdjBllQVCQGKXXt/Khx0kqmRgnplTazM/wQ DArzlwJDid001KIix8b+uUZjK68L9ny11x3uP70XrtTvNgm4gVVpFDphjYWwFIUv+Bx9 54sn8jGLvYod6qZxVOYPHX6TsHRxbyn70Cl1xac41Xcr5kjIiP8F5l8DkcGJXIHNke1J Yzbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=QD4WZM3V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g27si51779ejc.32.2021.03.10.09.46.29; Wed, 10 Mar 2021 09:46:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=QD4WZM3V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232792AbhCJRp0 (ORCPT + 99 others); Wed, 10 Mar 2021 12:45:26 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33960 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbhCJRo7 (ORCPT ); Wed, 10 Mar 2021 12:44:59 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12AHhOmt054518; Wed, 10 Mar 2021 12:44:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=Mn8sY8sJqOTDe7oikzYLEpWDu7TaX1hz5Zzib5aMyfk=; b=QD4WZM3VtiTUeDP23sZI8koJqNWM6a/altyzvE+4dOTo14GMyYE9GzRAmKqfyF3np3mT KCz3Iy9hxGaG9ME5xND+nvGF3GC1MOW8IKRECzDEc9atEeflNNKYWFX6do2XpyPDeMcs Rt0OBlVsk5RFBrhb9nNPIAdf346lQubOKhYxeDy+sguzuD0FXt7uKABOe2wjHOWdoDpv dOh/28SejY1uX+vEXREosOwH4vaf1JLUkclMLmxURGKhGyZ9BsIqeQSOUsKCFtNJ8Bmu Dl6/Pm8kSAS4hreA83PMfthYxHt3nNaGsADYTDoq5+MN3FCzLyD7Ggq0WL9jlGnJsGuT gQ== Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 3772ru03k5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Mar 2021 12:44:52 -0500 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12AHevDr002545; Wed, 10 Mar 2021 17:44:10 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma03fra.de.ibm.com with ESMTP id 3768mprmsk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Mar 2021 17:44:09 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12AHi7xn42205572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Mar 2021 17:44:07 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDE7311C04C; Wed, 10 Mar 2021 17:44:06 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7CBFE11C04A; Wed, 10 Mar 2021 17:44:06 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.162.110]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 10 Mar 2021 17:44:06 +0000 (GMT) From: Laurent Dufour To: fbarrat@linux.ibm.com, ajd@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clombard@linux.ibm.com Subject: [PATCH] cxl: don't manipulate the mm.mm_users field directly Date: Wed, 10 Mar 2021 18:44:05 +0100 Message-Id: <20210310174405.51044-1-ldufour@linux.ibm.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-10_10:2021-03-10,2021-03-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1011 impostorscore=0 mlxlogscore=745 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103100084 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is better to rely on the API provided by the MM layer instead of directly manipulating the mm_users field. Signed-off-by: Laurent Dufour --- drivers/misc/cxl/fault.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/fault.c b/drivers/misc/cxl/fault.c index 01153b74334a..60c829113299 100644 --- a/drivers/misc/cxl/fault.c +++ b/drivers/misc/cxl/fault.c @@ -200,7 +200,7 @@ static struct mm_struct *get_mem_context(struct cxl_context *ctx) if (ctx->mm == NULL) return NULL; - if (!atomic_inc_not_zero(&ctx->mm->mm_users)) + if (!mmget_not_zero(ctx->mm)) return NULL; return ctx->mm; -- 2.30.1