Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp478598pxf; Wed, 10 Mar 2021 10:00:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxoRh5BnE9VxzDGzEpIwkcsSkbjGz2URs9IzmTbrfoi2HpqA53eKRaGcnc8Ax25RgjIrJkN X-Received: by 2002:a17:907:98f5:: with SMTP id ke21mr4955690ejc.552.1615399237696; Wed, 10 Mar 2021 10:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615399237; cv=none; d=google.com; s=arc-20160816; b=v2FvTWUfiDvdpARvYd2gfLG0Koi/5diEhENeauOTIJd7oeV7lZIL2cfL/rsQrW3B1H z9IIRb8fGGZ5T7WeV1SQza1JuxwXc4xbUlRfZVQOLwOhtYqAgkYp0hycEqJkSNPpAkeB yudWbp8EJvFpN98tqF2FTWd6EJmlsNI9029zQuLnVKBar3v6an0F/R0scnLp5nYEmx2b FefFOWBkWf0DXsVYvt7Zspom44T9csdwY2SNHT7GkUVdrBi1r++5QsvSEi4DYixj3P80 ORysdDURaImi91S6surIw++SUwjUyIFHHTDD7gqzWLd8BdqEIOvWZDBrlQphtjsSC9sr Yrqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:cc:to:subject:from:references:in-reply-to :message-id; bh=SvPx7ZJqm63kU3rsDxi6ubFRp8buaX7DjU252iA8mgI=; b=virlboUWlbhR12ucHVG5X1pLspfcXNWN00ekBUYCvIi7CtFn7wGtqQAuV39s6CKaAV 9/jcBnoHtBm7h6nNgiKL6l3ttMcRpBvOIaHEgllsceAc16HG3qs55sX4uyQtKfaOJOvA ttdRMTUf7SOSqDjPanDDGVHQztvji73TwWd7AowVZpB95bldSiW1Quh9A36nzJ4isgTj DrKfckuxcq40hNvK95/cvfsG7irqzzFiHvEJbT3LppwsGur8mdQ71eDFH15ihQqKB6kL F00Qk4VjFKaqqYJYG2wijUag6fsIZrttHZNSFV/mcvh4EhFODC66MW2+Ex9fXnlNT4R7 VTFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si42019ejm.215.2021.03.10.10.00.14; Wed, 10 Mar 2021 10:00:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233450AbhCJR5U (ORCPT + 99 others); Wed, 10 Mar 2021 12:57:20 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:30178 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233392AbhCJR5H (ORCPT ); Wed, 10 Mar 2021 12:57:07 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Dwfsr5xqrz9twh2; Wed, 10 Mar 2021 18:57:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id OFJoXMI6JhO8; Wed, 10 Mar 2021 18:57:04 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Dwfsr4tG8z9v0W3; Wed, 10 Mar 2021 18:57:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 87A1B8B78D; Wed, 10 Mar 2021 18:57:06 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id ywr1m5Sj8eQn; Wed, 10 Mar 2021 18:57:06 +0100 (CET) Received: from po16121vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3B7188B77E; Wed, 10 Mar 2021 18:57:06 +0100 (CET) Received: by po16121vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 9ED896756B; Wed, 10 Mar 2021 17:57:05 +0000 (UTC) Message-Id: <2dee286d2d6dc9a27d99e31ac564bad4fae2cb49.1615398498.git.christophe.leroy@csgroup.eu> In-Reply-To: References: From: Christophe Leroy Subject: [PATCH v1 6/8] powerpc/net: Switch csum_and_copy_{to/from}_user to user_access block To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Wed, 10 Mar 2021 17:57:05 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use user_access_begin() instead of the might_sleep/access_ok/allow_access sequence. Signed-off-by: Christophe Leroy --- arch/powerpc/lib/checksum_wrappers.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/lib/checksum_wrappers.c b/arch/powerpc/lib/checksum_wrappers.c index b895166afc82..f3999cbb2fcc 100644 --- a/arch/powerpc/lib/checksum_wrappers.c +++ b/arch/powerpc/lib/checksum_wrappers.c @@ -16,16 +16,12 @@ __wsum csum_and_copy_from_user(const void __user *src, void *dst, { __wsum csum; - might_sleep(); - - if (unlikely(!access_ok(src, len))) + if (unlikely(!user_read_access_begin(src, len))) return 0; - allow_read_from_user(src, len); - csum = csum_partial_copy_generic((void __force *)src, dst, len); - prevent_read_from_user(src, len); + user_read_access_end(); return csum; } EXPORT_SYMBOL(csum_and_copy_from_user); @@ -34,15 +30,12 @@ __wsum csum_and_copy_to_user(const void *src, void __user *dst, int len) { __wsum csum; - might_sleep(); - if (unlikely(!access_ok(dst, len))) + if (unlikely(!user_write_access_begin(dst, len))) return 0; - allow_write_to_user(dst, len); - csum = csum_partial_copy_generic(src, (void __force *)dst, len); - prevent_write_to_user(dst, len); + user_write_access_end(); return csum; } EXPORT_SYMBOL(csum_and_copy_to_user); -- 2.25.0