Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp580855pxf; Wed, 10 Mar 2021 12:19:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzV4U69VLudaVECTFp93p8SZfaWeG877BMFU8Xia1Okn9939b1ywK0iIwE7DSLbmWTmYMBU X-Received: by 2002:a17:906:a049:: with SMTP id bg9mr214039ejb.186.1615407564643; Wed, 10 Mar 2021 12:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615407564; cv=none; d=google.com; s=arc-20160816; b=Z7xtufYwbV3tOjtZ9Aq7mRhJd4LqvNvyOmoMrDse2hQuzCtqhAK4hHvnSu9ZpwxhSW cFOmLNNl4kBIa6q+l62wGm+hJweR6dTt20r5EF2CKGxCxdNBk1wpVV0dAnWyMAgX2cf+ 87P/tQ9nG0J3MiDiTjvkIA9TjgQeC42EtJ/p3lonEmnjUOpwACWHwyy6K+C3gYxZ64fw ISk7WrnLgO11z02TSB9FI9mYUkKE+STCyvS6SzLVwXbKQJfSuto6uJ3VMvDBa2fdATYN ahjm26VIETiXOTBtSNAbfAElQrr/Pez6uoH4ZpACgeECBM3x7MfiZWI74QPHM1eVbUmA 55ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=22tESQIORWwnjVfGnwjn+fBTqJ+OKmI3PPmG59IpzFc=; b=s9gCS6h5LCbg0yVFBPHJSL4oFP2VOhz2lnC2DkZk8J10TUYV9JPWPWNpCjeGfZCEfE SIEfVIKFp3svW5pOaccPdGMwtXNqHQRVeBJNKULDw5LyXpyqN/LuWjj1gsbaLrmc5vYN 2VOqAO725p9jGcLtI/mNssHt8r8x53zLxEvIci652csI5XCMCK6jFqQH6yyvwqumv8tN DcGw/xAFMIQN6yjFIp2WV1fbBs6EUJrWK4PdN+P3qoz6G1sVETtDJZezczfKfNO37rGH DFRipWzoreDRiRKpdfxpIEYdkJ6m3tWJ+sjkyhRrvpnaH13YRJj5//+FqO8LSB+5FjTq ZXGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L57vt6Er; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si255115ejg.131.2021.03.10.12.19.01; Wed, 10 Mar 2021 12:19:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L57vt6Er; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbhCJUR5 (ORCPT + 99 others); Wed, 10 Mar 2021 15:17:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:54658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhCJURe (ORCPT ); Wed, 10 Mar 2021 15:17:34 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E735F64FB3; Wed, 10 Mar 2021 20:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615407454; bh=22tESQIORWwnjVfGnwjn+fBTqJ+OKmI3PPmG59IpzFc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L57vt6Er2TEZ7xI53hKEVh/9U3//HFqey7UDMI/eaSqhjvvU/3JXz8hF4E4E/0gRW dTVDBfq8ofbwGNvXfOvW5yMhI2mRUoCOQO3c0uz+3dJdWGWQ8TN6qU8l6WZptSBuVc KTPo3IaUcfU4gKFKAA4NYn3NRibSG5B053rzNrL+VAbYfKkFb4I12uHFynn8uzGqEQ tJ63O0TXO5Xh1dXMK3bY8u+XEYRyJ9WS0OtQzbXrmUfsm6it9joAAR6fa3wmFswQE6 wKPyAsHd7RG8qRT6tb2aplCB1vwoH64mscEWrMuPiTVS3xgaPgb64jgtF+lL5V2OF1 MHJTXrpiKp9bg== Date: Wed, 10 Mar 2021 20:16:22 +0000 From: Mark Brown To: Jon Hunter Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Kai Vehmanen , Takashi Iwai , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, Ranjani Sridharan , linux-tegra@vger.kernel.org, Bard liao Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present Message-ID: <20210310201622.GF28564@sirena.org.uk> References: <20210310133534.GD4746@sirena.org.uk> <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> <20210310161814.GA28564@sirena.org.uk> <9b073d01-f2fe-a99b-e53c-4a0b3f95ca05@linux.intel.com> <20210310165235.GD28564@sirena.org.uk> <20210310181611.GE28564@sirena.org.uk> <9e1075c6-da49-d614-e7af-30242dd3d3fe@linux.intel.com> <9020a65c-b8b8-ac1e-d0f8-a12e507322b8@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Wb5NtZlyOqqy58h0" Content-Disposition: inline In-Reply-To: <9020a65c-b8b8-ac1e-d0f8-a12e507322b8@nvidia.com> X-Cookie: Yow! Are we laid back yet? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Wb5NtZlyOqqy58h0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 10, 2021 at 07:17:13PM +0000, Jon Hunter wrote: > On 10/03/2021 18:37, Pierre-Louis Bossart wrote: > > +EXPORT_SYMBOL_GPL(dmi_available); > > -=A0=A0=A0=A0=A0=A0 if (!is_acpi_device_node(card->dev->fwnode)) > > +=A0=A0=A0=A0=A0=A0 if (!dmi_available) > Sounds good to me. I would have done the same if I had known that the > current solution would have caused this regression. Yes, this looks good. --Wb5NtZlyOqqy58h0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBJKRUACgkQJNaLcl1U h9Do/Qf9GmQSmIRRH5Rx5BD9lm0loP+WMo4oztmA5BvnLrrnSgf2K+wOlWAG9Kgz kya+OGtjauw1NImpC086m07bV39/APPw/ag4ZC8neDY8u1BCdebYNGxoLNd61OSS W6EnONmDY0axTAwTnNwt3CCp/Q4hiXtuuQvYy1o91mF7RJv9hwAs8rpFjId/yZ/1 AmOiaklO+mRU3Cyysmz/wuYoHXO/j82Ftuhn4XgBKn/vl2kpRQ5pbnCJl0e3X4MA NB+Ks0DefrXiHfRocACmQLUcCxXCd07KnM/3T9oPdURYRQrklqUjbyiAdqrjbQYR PV/F+VNwl+q08hwHT31LEW3nY1+xCA== =atzH -----END PGP SIGNATURE----- --Wb5NtZlyOqqy58h0--