Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
To:     Nicolin Chen <nicoleotsuka@gmail.com>, joro@8bytes.org,
        thierry.reding@gmail.com, will@kernel.org
Cc:     vdumpa@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20210310033614.16772-1-nicoleotsuka@gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <cc5dca8f-e9b0-a845-1af4-e762782d5441@gmail.com>
Date:   Wed, 10 Mar 2021 23:38:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <20210310033614.16772-1-nicoleotsuka@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

10.03.2021 06:36, Nicolin Chen пишет:
> This patch dumps all active mapping entries from pagetable
> to a debugfs directory named "mappings".
> 
> Ataching an example:
> 
> SWGROUP: hc
> ASID: 0
> reg: 0x250
> PTB_ASID: 0xe0080004
> as->pd_dma: 0x80004000
> {
>         [1023] 0xf0080013 (1)
>         {
>                 PTE RANGE       PHYS           IOVA        SIZE        ATTR
>                 #1023 - #1023   0x122e5e000    0xfffff000  0x1000      0x5
>         }
> }
> Total PDE count: 1
> Total PTE count: 1

Addresses are 32bit on ARM32, please fix the formatting. The phys_addr_t
and dma_addr_t have special printk specifiers [1].

[1]
https://www.kernel.org/doc/html/latest/core-api/printk-formats.html?highlight=printk#physical-address-types-phys-addr-t

as->pd_dma: 0xc026e81b0000026c
{
        [0] 0xf0082848 (1024)
        {
                PTE RANGE       PHYS           IOVA        SIZE
ATTR
                #0    - #15     0xc0f9fc40bfde0000 0x0         0x10000
   0x7
                #16   - #47     0xc0f9fc40bfdc0000 0x10000     0x20000
   0x7
                #48   - #111    0xc0f9fc40bfd80000 0x30000     0x40000
   0x7
                #112  - #239    0xc0f9fc40bfd00000 0x70000     0x80000
   0x7
                #240  - #495    0xc0f9fc40bfc00000 0xf0000     0x100000
   0x7
                #496  - #999    0xc0f9fc40bf400000 0x1f0000    0x1f8000
   0x7
                #1000 - #1000   0xc0f9fc40acc40000 0x3e8000    0x1000
   0x7
                #1001 - #1001   0xc0f9fc40bbb95000 0x3e9000    0x1000
   0x7
                #1002 - #1002   0xc0f9fc40bbb97000 0x3ea000    0x1000
   0x7
                #1003 - #1003   0xc0f9fc40bbb91000 0x3eb000    0x1000
   0x7
                #1004 - #1005   0xc0f9fc40bb455000 0x3ec000    0x2000
   0x7
                #1006 - #1006   0xc0f9fc40bee9c000 0x3ee000    0x1000
   0x7
                #1007 - #1007   0xc0f9fc40bed20000 0x3ef000    0x1000
   0x7
                #1008 - #1008   0xc0f9fc40bbde0000 0x3f0000    0x1000
   0x7
                #1009 - #1009   0xc0f9fc40be465000 0x3f1000    0x1000
   0x7
                #1010 - #1010   0xc0f9fc40bb505000 0x3f2000    0x1000
   0x7
                #1011 - #1011   0xc0f9fc40bdcb9000 0x3f3000    0x1000
   0x7
                #1012 - #1012   0xc0f9fc40bcdf9000 0x3f4000    0x1000
   0x7
                #1013 - #1013   0xc0f9fc40bb6ce000 0x3f5000    0x1000
   0x7
                #1014 - #1014   0xc0f9fc40bcd74000 0x3f6000    0x1000
   0x7
                #1015 - #1015   0xc0f9fc40bd0d0000 0x3f7000    0x1000
   0x7
                #1016 - #1016   0xc0f9fc40bb6c5000 0x3f8000    0x1000
   0x7
                #1017 - #1017   0xc0f9fc40bd121000 0x3f9000    0x1000
   0x7
                #1018 - #1018   0xc0f9fc40bb6df000 0x3fa000    0x1000
   0x7
                #1019 - #1020   0xc0f9fc40bb6e9000 0x3fb000    0x2000
   0x7
                #1021 - #1021   0xc0f9fc40bb713000 0x3fd000    0x1000
   0x7
                #1022 - #1022   0xc0f9fc40bb738000 0x3fe000    0x1000
   0x7
                #1023 - #1023   0xc0f9fc40be444000 0x3ff000    0x1000
   0x7
        }