Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <91cda49d4fda10781dc2add8174536cf6b91a527.camel@archlinux.org>
Subject: Re: Logitech G602 wireless mouse kernel error messages in 5.10.11+
 kernels
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <lains@archlinux.org>
To:     markh@compro.net, Jiri Kosina <jkosina@suse.cz>, sashal@kernel.org,
        Linux-kernel <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <8276a207-abe7-06cc-0c25-f4eebf1a9525@compro.net>
References: <ac5dde9c-194f-ce40-5c13-2a6890fad6a9@compro.net>
         <bb840ecf8dc626a07b9f00af69b0d561fb60f75b.camel@archlinux.org>
         <8276a207-abe7-06cc-0c25-f4eebf1a9525@compro.net>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-BdjneROPG+yI9508ZaBV"
Date:   Wed, 10 Mar 2021 20:55:12 +0000
MIME-Version: 1.0
User-Agent: Evolution 3.38.4 
Precedence: bulk


--=-BdjneROPG+yI9508ZaBV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2021-03-10 at 15:24 -0500, Mark Hounschell wrote:
>=20
> That is correct, I don't have any buttons bound to keyboard events. With=
=20
> the original patch the G4(forward) and G5(Backward) buttons work in a=20
> browser. I guess G7, G8, and G9 buttons are programmable to keyboard even=
ts?
>=20
> However this patch does not seem to fix the messages I get.
>=20
> Regards
> Mark

Those events belong to the USB HID button usage page and are sent by the
receiver in the HID device with the unnumbered report descriptor, so they a=
re
not affected.

Looking at the report descriptor for the other HID device, I see a report I=
D of
128 (0x80) used for a vendor application, I am not really sure what it is u=
sed
for and can't seem to trigger my device to send it.

I am gonna guess this is the device reporting the pressed buttons via vendo=
r
reports or something like that. Speaking as the person who added support fo=
r
this device in libratbag, this report is very likely not something that we =
don't
need in our custom drivers and just likely something extra that Logitech bu=
ilt
to achieve something custom in the Windows driver. FWIW, this device is a v=
ery
weird one, it does not even follow Logitech's own spec :P

Seeing this report the driver chugs.

	if (report > REPORT_TYPE_RFREPORT_LAST) {
		hid_err(hdev, "Unexpected input report number %d\n", report);
		return;
	}

Causing your

[   36.471326] logitech-djreceiver 0003:046D:C537.0002: Unexpected input re=
port number 128
[   36.565317] logitech-djreceiver 0003:046D:C537.0002: Unexpected input re=
port number 128
[   42.390321] logitech-djreceiver 0003:046D:C537.0002: Unexpected input re=
port number 128

I feel like the correct fix for these cases is not to consume the report an=
d not
forward it to device node, but rather to forward it to the receiver node.

(looping in Hans)
Hans, you introduced this code, do you remember why? Where did
REPORT_TYPE_RFREPORT_LAST get its value from and what is the purpose of thi=
s
check?
Shouldn't we just keep forwarding unknown reports to the receiver node? Is =
there
any technical limitation to do that? I am not too familiar with this part o=
f the
code.

Cheers,
Filipe La=C3=ADns

--=-BdjneROPG+yI9508ZaBV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAmBJMiYACgkQ+JPGdIFq
qV1nHQ/+O0N28W7t9mA6prszQLBd9rusR1tLz46U8UBIeJuKg+bP0JNntJBomF+B
t7vtqvl0feG3liKkmJ/PesoJa6U2xyfsC6Dc7G5TTMA+FPoJ/dj7vZHzD/B3DlDf
Idx4bkK5uSsdS4PkQe7ePoddcOruqyLum4hPhgH9DRdT8hwy7NlLVxx31mwdCLcD
kpfkYz00+wncoA9DhiR2Z5b3MEly0BkQXUq04iuKinbZQwZMBwsOXJlIMJJoIqRx
ycbzDPGRy6JZvz1gPk4FcnsSa1IC3P2OHz6V3W1yx+3LKv0uhdx5nyrk6bTwc1tP
m7ZOvAmFUhFvwwEQ9OOJjuAVqhoXcivYVMfjoxeIfjOmuI0EhHxP/BzHX5xMW5ln
xXAWeOsNii5HhBLRjRpri4rIAWFo+U8F+Gazjg7omPRlLbl59dCZKxXaSycj/nhT
Xoh7JxO7qlY9qtjBNQsMMPJAFwgLkz8OdWhW6A/ediMaBL78xg9PTlUbrfxStMVd
mekD+pxz0/s1e4KJdd4mVeeKDcIC5u6sZLUur/N5R6pizPNsEjTE3vVlNUsyLeGT
B4fPV2bNrXslxw86zeXnE11RvAZNwDI9b2zCYcbKUzP0Ic1agRyUaSEuiWIGn29Y
3ZurU1jabSIUKbHTBEZI2iuMpqGIA6blREdPmjMUGi7GVw9VHb4=
=A7iO
-----END PGP SIGNATURE-----

--=-BdjneROPG+yI9508ZaBV--