Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210308152501.2135937-1-arnd@kernel.org> <20210310193246.GA2033984@bjorn-Precision-5520>
In-Reply-To: <20210310193246.GA2033984@bjorn-Precision-5520>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Wed, 10 Mar 2021 22:02:55 +0100
Message-ID: <CAK8P3a2tNAqjSSP4g6dguT58C4DUGUT4Jgf-Osa1Da03cecLRQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 10, 2021 at 8:32 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Compile-testing this driver without ECAM support results in a link
> > failure:
> >
> > ld.lld: error: undefined symbol: pci_ecam_map_bus
> > >>> referenced by pcie-al.c
> > >>>               pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a
> >
> > Select CONFIG_ECAM like the other drivers do.
>
> Did we add these compile issues in the v5.12-rc1?  I.e., are the fixes
> candidates for v5.12?

No, the bug exists but is hidden until you apply patch 3/3 because the
driver is never compile tested on anything other than arm64, which
turns on PCI_ECAM unconditionally.

Merging all three for 5.13 is sufficient.

       Arnd