Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210310004511.51996-1-peterx@redhat.com>
In-Reply-To: <20210310004511.51996-1-peterx@redhat.com>
From:   Axel Rasmussen <axelrasmussen@google.com>
Date:   Wed, 10 Mar 2021 13:26:29 -0800
Message-ID: <CAJHvVcj0JUtV8VFAa_CftEN7-ohNLhcnfpmM-zny2aVvc0a2ug@mail.gmail.com>
Subject: Re: [PATCH 0/5] userfaultfd/selftests: A few cleanups
To:     Peter Xu <peterx@redhat.com>
Cc:     Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

These look like good cleanups to me! I reviewed all of the patches,
and tried out the resulting selftest program, it seems to work
correctly. So, for what it's worth:

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>


On Tue, Mar 9, 2021 at 4:45 PM Peter Xu <peterx@redhat.com> wrote:
>
> Based on v5.12-rc2-mmots-2021-03-08-21-54.
>
> I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not
> cleaned, when the new code grows the file it'll also grow the size that needs
> to be cleaned...  This is my attempt to cleanup the userfaultfd selftest on
> fault handling, to use an err() macro instead of either fprintf() or perror()
> then another exit() call.
>
> The huge cleanup is done in the last patch.  The first 4 patches are some other
> standalone cleanups for the same file, so I put them together.
>
> Please review, thanks.
>
> Peter Xu (5):
>   userfaultfd/selftests: Use user mode only
>   userfaultfd/selftests: Remove the time() check on delayed uffd
>   userfaultfd/selftests: Dropping VERIFY check in locking_thread
>   userfaultfd/selftests: Only dump counts if mode enabled
>   userfaultfd/selftests: Unify error handling
>
>  tools/testing/selftests/vm/userfaultfd.c | 742 +++++++----------------
>  1 file changed, 235 insertions(+), 507 deletions(-)
>
> --
> 2.26.2
>
>