Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Mar 2021 14:08:09 -0800
From:   Nicolin Chen <nicoleotsuka@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     joro@8bytes.org, thierry.reding@gmail.com, will@kernel.org,
        vdumpa@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
Message-ID: <20210310220808.GA10431@Asurada-Nvidia>
References: <20210310033614.16772-1-nicoleotsuka@gmail.com>
 <cc5dca8f-e9b0-a845-1af4-e762782d5441@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cc5dca8f-e9b0-a845-1af4-e762782d5441@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Mar 10, 2021 at 11:38:47PM +0300, Dmitry Osipenko wrote:
> 10.03.2021 06:36, Nicolin Chen пишет:
> > This patch dumps all active mapping entries from pagetable
> > to a debugfs directory named "mappings".
> > 
> > Ataching an example:
> > 
> > SWGROUP: hc
> > ASID: 0
> > reg: 0x250
> > PTB_ASID: 0xe0080004
> > as->pd_dma: 0x80004000
> > {
> >         [1023] 0xf0080013 (1)
> >         {
> >                 PTE RANGE       PHYS           IOVA        SIZE        ATTR
> >                 #1023 - #1023   0x122e5e000    0xfffff000  0x1000      0x5
> >         }
> > }
> > Total PDE count: 1
> > Total PTE count: 1
> 
> Addresses are 32bit on ARM32, please fix the formatting. The phys_addr_t
> and dma_addr_t have special printk specifiers [1].
> 
> [1]
> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html?highlight=printk#physical-address-types-phys-addr-t
> 
> as->pd_dma: 0xc026e81b0000026c
> {
>         [0] 0xf0082848 (1024)
>         {
>                 PTE RANGE       PHYS           IOVA        SIZE
> ATTR
>                 #0    - #15     0xc0f9fc40bfde0000 0x0         0x10000

Thanks for the feedback! I will send v3.