Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Mar 2021 23:45:49 +0100
From:   Fabio Aiuto <fabioaiuto83@gmail.com>
To:     Eric Curtin <ericcurtin17@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: align comments
Message-ID: <20210310224548.GA3399@agape.jhs>
References: <20210310153717.GA5741@agape.jhs>
 <YEjrEErDZTH47gto@kroah.com>
 <20210310160946.GA6421@agape.jhs>
 <CANpvso71zHTHJBduzrX7wx=gDN9mi2CEaXskF=TaZZoL-2+V_Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANpvso71zHTHJBduzrX7wx=gDN9mi2CEaXskF=TaZZoL-2+V_Q@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Mar 10, 2021 at 10:27:53PM +0000, Eric Curtin wrote:
> Hi Fabio,
> 
> > I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> > Where have I to add a ' ' (a blank?)?
> >
> > thank you,
> >
> > fabio
> >
> 
> I'm only responding to this because this email is doing a very good job
> of avoiding my filters somehow :) I think what Greg means is:
> 
> Change this:
> 
>  /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> -       - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> -       - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> -       in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> -       however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> -       (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
> + *Set to 0 (HT pure) under the following conditions
> + *      - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + *      - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> + *      in both the primary and the secondary channel
> + *Set to 2 if only HT STAs are associated in BSS,
> + *      however and at least one 20 MHz HT STA is associated
> + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + *      (currently non-GF HT station is considered as non-HT STA also)
> + */
> 
> to this:
> 
>  /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> -       - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> -       - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> -       in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> -       however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> -       (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + * op_mode
> + * Set to 0 (HT pure) under the following conditions
> + *      - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + *      - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + * Set to 1 (HT non-member protection) if there may be non-HT STAs
> + *      in both the primary and the secondary channel
> + * Set to 2 if only HT STAs are associated in BSS,
> + *      however and at least one 20 MHz HT STA is associated
> + * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + *      (currently non-GF HT station is considered as non-HT STA also)
> + * /
> 
> Like Dan said, you need a space after the '*'/
> 
> Is mise le meas/Regards,
> 
> Eric Curtin
> 
> Check out this charity that's close to my heart:
> 
> https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html
> https://www.facebook.com/Peak-for-Pat-104470678280309
> https://www.instagram.com/peakforpat/

thank you, Eric :)