Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp677104pxf; Wed, 10 Mar 2021 15:06:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGjh7YYvNXnSagB2tKiqmhRY5F58LwRcRRgp4kRkJwqoBuhdn13+qJccTV3DC1jcNmYpVN X-Received: by 2002:a17:906:d9d1:: with SMTP id qk17mr253689ejb.52.1615417594620; Wed, 10 Mar 2021 15:06:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615417594; cv=none; d=google.com; s=arc-20160816; b=azEe/861M+969tmnC5sYeXH5YZUlCfmcW302cCBbHFlNRortWK5oGPnfNRZih1+tkj WmzzOFkpWgWXc16wbuVEVTDNhcWweQlTokkmmAAT6W1I3gC1K8Ik2fbEvaJTjVYUkYfh y5+OCgwTSJRfc8zAYqrf5vWbdcV7Oc8OjsIBc6iWEzM1ff1achEOhAK+aXxXIyMENXMY i3x2UQGLKmJJ8DxH/pw1F/0c8mOcyCYzea73mNkKboavVk6+ZD1TfnX7O/8vMtSDNi/9 FvIefMHjsgDRss2QQKgByiSLwVFHN4RVCJBbWzO14hhUUjGPsDIqXANtsbiMiPW14CM8 H/Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JY8aT8I/V8Xh83sQyQHsi9SRFbjqxWHIbyIFLZJpgug=; b=fynJqQIpCzoEqTg4PXT7HRxZXp6QetIextTNN9gWw45irjIvqOf2fxti3pw7/fFeC9 kTQt0rscmfajHfDKxYRm/owQsZHPM9HzqCUIrrnd2Jr6Ai7g+Up/CiYzJb57BnmUzTBQ 3wTlTu/9WypbxjX5yF/kcaGA42C09uL23fzyN5O5UKZl6PxkwHQ3Tvt1DosA673Ld2xG n45As2DOxe5+RCeDOGWO7ArOPlcz+4U0O35y4hzxMbslvRj4GeH8sxm49eXn8H2uHFtC sJ5Mf9GrQRSeTThCz/N1Q1F109dM+5CyU/iqJshI6yJ22JA6qn7o1Rx7wNu28lj89dOn RhQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t+tHJaSd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si499363eja.553.2021.03.10.15.06.12; Wed, 10 Mar 2021 15:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t+tHJaSd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233150AbhCJXFF (ORCPT + 99 others); Wed, 10 Mar 2021 18:05:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:35130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231368AbhCJXEi (ORCPT ); Wed, 10 Mar 2021 18:04:38 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DB6964FAE; Wed, 10 Mar 2021 23:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615417478; bh=WzmZkaUunjZxXsa1qc4s/xR3aKCgsgPzwcOMV3ukiB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t+tHJaSdx8Yn9NL8OrPfepU/PMDh4p/zPHQOzP4BFGkcIOY3dyuBGUxXJw7QDaOxy VeCwVyPIdsQ0lIvrw/JyeIjdozo6oifhlg0MFAd1CUcbKrU6mELRl2b8LcRJGiF9+2 avbTjiI1zCr/txFUWHPeUYOvqhikvmAWVuuMbanNOJWIMYmZK4ya4MHcqke6y3pKhf yTuxCc2pdGwb04gy06wWIVcnBxCDRNv+GAQrQu+P0K+j6+PsDuX0x+Hq77GBmj0H/z /kSkjUp+4dolV4AuTHDE7gkZ4nA1RplGJWpgtIBVLLogOnjU8M2DJVHmamaKvVT8g/ iN912YIhCkwkw== Date: Thu, 11 Mar 2021 01:04:13 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Fix bugs related to TPM2 event log Message-ID: References: <20210310221916.356716-1-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210310221916.356716-1-stefanb@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 05:19:13PM -0500, Stefan Berger wrote: > This series of patches fixes a couple of issues related to TPM2 > event logs, such as the disappearance of the TPM2 log on QEMU machines > running with UEFI (my fault) and a kernel fault due to an integer under- > flow when reading the TPM 2 log multiple times. > > Regards, > Stefan > > v1->v2: > - Revised patches 1 & 2 > > Stefan Berger (3): > tpm: efi: Use local variable for calculating final log size > tpm: acpi: Check eventlog signature before using it > tpm: vtpm_proxy: Avoid reading host log when using a virtual device > > drivers/char/tpm/eventlog/acpi.c | 33 +++++++++++++++++++++++++++++- > drivers/char/tpm/eventlog/common.c | 3 +++ > drivers/char/tpm/eventlog/efi.c | 29 ++++++++++++++++++-------- > 3 files changed, 56 insertions(+), 9 deletions(-) > > -- > 2.29.2 > > b4 seems like remarkably useful tool: $ b4 am 20210310221916.356716-1-stefanb@linux.ibm.com Looking up https://lore.kernel.org/r/20210310221916.356716-1-stefanb%40linux.ibm.com Grabbing thread from lore.kernel.org/linux-integrity Analyzing 4 messages in the thread --- Writing ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx ✓ [PATCH v2 1/3] tpm: efi: Use local variable for calculating final log size ✓ [PATCH v2 2/3] tpm: acpi: Check eventlog signature before using it ✓ [PATCH v2 3/3] tpm: vtpm_proxy: Avoid reading host log when using a virtual device --- ✓ Attestation-by: DKIM/ibm.com (From: stefanb@linux.ibm.com) --- Total patches: 3 --- Cover: ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.cover Link: https://lore.kernel.org/r/20210310221916.356716-1-stefanb@linux.ibm.com Base: not found (applies clean to current tree) git am ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx $ git am -3 v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx Applying: tpm: efi: Use local variable for calculating final log size Applying: tpm: acpi: Check eventlog signature before using it Applying: tpm: vtpm_proxy: Avoid reading host log when using a virtual device I also did run checkpatch.pl, no errors. /Jarkko