Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp707763pxf; Wed, 10 Mar 2021 16:00:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwIe2noMOCTHQ3zHJKtmoC6W2axfyi4omtTBSts6DEsbaCJPl+zshHzwEJYBC66VesHEh9 X-Received: by 2002:a17:906:828e:: with SMTP id h14mr381702ejx.529.1615420818395; Wed, 10 Mar 2021 16:00:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615420818; cv=none; d=google.com; s=arc-20160816; b=J2KrROq/gRfPRLuWZ60XWoUVZ+Vkisk65wUmZc8MzZBtnE8eiiAy1QMW7TLg2NZTPe bowsQrJfAZOzV9Nqf1oCb47Xbb+BEOu0AlLTpH80XoVdbNu2YTF9c3mf1QqNtZEz1Cqc p8DlPVEDvqtxcLnq7lo8sIFRx+gn5eqe4U7XQQ3pcKLsduNlfH0CHbSqP1jeVsH4bbHr DEYObg6FCIw0q/No39BC2Qa7jr4+vlRlWtcDgKMAiNOVhcMuodiAxv8ma5XmBrRb6ZGB aBAyPMVvhkO+4HeUty3xoit8m/FLDkgHZCVcIhi8M7CznrTZ+wn3UC82Bqmlfjb8HAMa HUZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uFYq2dPYtqKGGbhqs7HMnBOC+yfdp5R5ga04sWFWLzA=; b=ag5K0TUD6Cj5jhNGu6KlUPElVlJ+DeIArK4sS6UqUriWBYaOYiF5ndWzD1Nz/PQT+z Upu5engiclHUvJKxDtEZiJyjYe61v9Fkbt8fDe5ntVEzpB1O3orUFRm2bGOPX2gwi5ZQ qZygS7tuBHai64zVtgxldy+td5RC4MrevhL25SzSH1J8X302B9tbOH9eXix0m0r7LqdC TVz6dCd4vsUqRmAlr5NEETiQAWoe+dy95Gz/FAekiTTm25E2nFzxjEBlh8/vwvC6dClu OaaGEOwkyPqoEE1+ItjQLqCengT3lTlt29vBX8hcdUK7NbHqYdnUv/zaygu4jaHRb+DD 9qyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=PWPbXbmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j19si532052edp.531.2021.03.10.15.59.55; Wed, 10 Mar 2021 16:00:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=PWPbXbmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhCJX67 (ORCPT + 99 others); Wed, 10 Mar 2021 18:58:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:43974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhCJX6i (ORCPT ); Wed, 10 Mar 2021 18:58:38 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 65D6364FA9; Wed, 10 Mar 2021 23:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1615420717; bh=luK33h5nP8fsBBPXEQ/QzxyI7Rp8lL7ssg1ESsYovco=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PWPbXbmUPDuaxxwOXGMFkJwz3+KhBbEuY0dtfsHo8Sp6E/u4pIWNAYPV0/JlduYuD 63m8KvxzeXoPX23tAUJI2hFEXYItkPBnssFlukQPvVU8R1ynC5STCBRMd8Wret/mzI CKTeuNgTh2jX1ACnNfv7LTQhGhnSnyFe3N6CuIUM= Date: Wed, 10 Mar 2021 15:58:36 -0800 From: Andrew Morton To: ira.weiny@intel.com Cc: David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] btrfs: Convert kmap/memset/kunmap to memzero_user() Message-Id: <20210310155836.7d63604e28d746ef493c1882@linux-foundation.org> In-Reply-To: <20210309212137.2610186-1-ira.weiny@intel.com> References: <20210309212137.2610186-1-ira.weiny@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Mar 2021 13:21:34 -0800 ira.weiny@intel.com wrote: > Previously this was submitted to convert to zero_user()[1]. zero_user() is not > the same as memzero_user() and in fact some zero_user() calls may be better off > as memzero_user(). Regardless it was incorrect to convert btrfs to > zero_user(). > > This series corrects this by lifting memzero_user(), converting it to > kmap_local_page(), and then using it in btrfs. This impacts btrfs more than MM. I suggest the btrfs developers grab it, with my Acked-by: Andrew Morton