Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] do_wait: make PIDTYPE_PID case O(1) instead of O(n)
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        Christian Brauner <christian@brauner.io>,
        linux-kernel@vger.kernel.org
References: <20210309203919.15920-1-jnewsome@torproject.org>
 <m1blbqmy2u.fsf@fess.ebiederm.org>
From:   Jim Newsome <jnewsome@torproject.org>
Organization: The Tor Project
Message-ID: <4d9006b4-b65a-6ce0-b367-971f29de1f21@torproject.org>
Date:   Wed, 10 Mar 2021 18:14:44 -0600
MIME-Version: 1.0
In-Reply-To: <m1blbqmy2u.fsf@fess.ebiederm.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/10/21 16:40, Eric W. Biederman wrote:
>> +// Optimization for waiting on PIDTYPE_PID. No need to iterate
through child
>> +// and tracee lists to find the target task.
>
> Minor nit:  C++ style comments look very out of place in this file
>             which uses old school C /* */ comment delimiters for
>             all of it's block comments.

Will do

>> +static int do_wait_pid(struct wait_opts *wo)
>> +{
>> +	struct task_struct *target = pid_task(wo->wo_pid, PIDTYPE_PID);
>                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This is subtle change in behavior.
> 
> Today on the task->children list we only place thread group leaders.

Shouldn't we allow waiting on clone children if __WALL or __WCLONE is set?

This is already checked later in `eligible_child`, called from
`wait_consider_task`, so I *think* the current form should already do
the right thing. Now I'm confused though how the general path (through
`do_wait_thread`) works if clone children aren't on the task->children
list...?

(In any case it seems this will need another version with at least an
explanatory comment here)

Thanks!
-Jim