Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965414AbWJBVen (ORCPT ); Mon, 2 Oct 2006 17:34:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965417AbWJBVen (ORCPT ); Mon, 2 Oct 2006 17:34:43 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51724 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S965411AbWJBVel (ORCPT ); Mon, 2 Oct 2006 17:34:41 -0400 Date: Mon, 2 Oct 2006 17:34:40 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: David Brownell cc: Andrew Morton , David Howells , Thomas Gleixner , Ingo Molnar , , , , Dmitry Torokhov , Greg KH Subject: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers In-Reply-To: <200610021346.13135.david-b@pacbell.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 24 On Mon, 2 Oct 2006, David Brownell wrote: > > > (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does > > > something different depending on whether it's been supplied with a regs > > > pointer or not. > > gaak! where did that come from? I'll be surprised if removing > that causes any problem at all. Here's the statement in question: if (likely (regs && HC_IS_RUNNING(ohci_to_hcd(ohci)->state))) { ... Notice another questionable use of hcd->state. I don't know what the correct change here is, but I suspect David H's isn't optimal. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/