Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] cxl: don't manipulate the mm.mm_users field directly
To:     Laurent Dufour <ldufour@linux.ibm.com>, ajd@linux.ibm.com,
        arnd@arndb.de, gregkh@linuxfoundation.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        clombard@linux.ibm.com
References: <20210310174405.51044-1-ldufour@linux.ibm.com>
From:   Frederic Barrat <fbarrat@linux.ibm.com>
Message-ID: <8daa454c-b2fd-d914-b170-62b6665e82d8@linux.ibm.com>
Date:   Thu, 11 Mar 2021 08:46:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210310174405.51044-1-ldufour@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/03/2021 18:44, Laurent Dufour wrote:
> It is better to rely on the API provided by the MM layer instead of
> directly manipulating the mm_users field.
> 
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---


Thanks!
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>


>   drivers/misc/cxl/fault.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/fault.c b/drivers/misc/cxl/fault.c
> index 01153b74334a..60c829113299 100644
> --- a/drivers/misc/cxl/fault.c
> +++ b/drivers/misc/cxl/fault.c
> @@ -200,7 +200,7 @@ static struct mm_struct *get_mem_context(struct cxl_context *ctx)
>   	if (ctx->mm == NULL)
>   		return NULL;
>   
> -	if (!atomic_inc_not_zero(&ctx->mm->mm_users))
> +	if (!mmget_not_zero(ctx->mm))
>   		return NULL;
>   
>   	return ctx->mm;
>