Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp209484pxf; Thu, 11 Mar 2021 01:50:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+Yj3bYyRuPKYq7eShRsuIFbht9TE7KBnTfkCBWT8bFI/xMuNd+NQAySKDMdqlAAj8t7jM X-Received: by 2002:a17:906:1352:: with SMTP id x18mr2185864ejb.545.1615456217189; Thu, 11 Mar 2021 01:50:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615456217; cv=none; d=google.com; s=arc-20160816; b=EL+a7BcPFhzrX1xfWfb1KRXiInmHKLcYfbOrdHpje21/cnK787Kf2Wmki628E90lY2 snrTchTmeNMo2nvkuOo0B1TB+ipoNtPvanRg4pAw2tjXND4Gpdva7Y3GNBtXFZhlawPo w/2ZET55LidTiJIqYQB8nxT/xc2oXDMoVMQNhCH4AzxqVVDUJxJijR/kxj5neDeBBi0R o6QuDePDZT5NuiCYvrrgIaCWluoXuJULlFP+jBQrR7zSyBFIL0ewspmyampXbeqKyFQx dAcg/G/7Ep/dwl46xpTwUXbuGkGiw8YCFmFe6pskFj4LGP8eYFN1/ZZIJYIHa9Psh2NV Lslw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Ue82mmrfI1P7A9sxCh0B1f2CaXjn0f78pdCaZRg4Ig4=; b=blaWlL4szpWWc77iS3bATk/DD9jfXwgAof1axZdeRJSGFVUNgI82dPoD0DX5mcP32O cJlw0amNELLXnMRqxhPRnvQac8Ui2cJ2rfOFy3UQLRCdTHeEz1ZylrLOBn9l4LtWkrZh gBBnaeCj3lhK7IoQBNoKfN9WKqdXUrXk0JgAPNi883U317aDYTdqj/fdFQyEfImHgyKv Q8JytwLlVtk3MMTgDcdWCRO8j1kLDZUfKzliWAUwv3euc/N89BzWQtaCumbuyyyvg94L /RaJJsOUb69kq7n78j1c7jB1nIAIlQgXDoNDgRhtKBKmHbXzfiQLoUAsjkIa0Tvr5pGm uk3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o26si1393674eja.611.2021.03.11.01.49.55; Thu, 11 Mar 2021 01:50:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232102AbhCKJsk (ORCPT + 99 others); Thu, 11 Mar 2021 04:48:40 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:49342 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbhCKJsO (ORCPT ); Thu, 11 Mar 2021 04:48:14 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0URS8WsQ_1615456087; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0URS8WsQ_1615456087) by smtp.aliyun-inc.com(127.0.0.1); Thu, 11 Mar 2021 17:48:12 +0800 From: Jiapeng Chong To: davem@davemloft.net Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ide: fix warning comparing pointer to 0 Date: Thu, 11 Mar 2021 17:48:06 +0800 Message-Id: <1615456086-127803-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index ea0b064..d5171e0 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -1677,7 +1677,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const struct ide_port_info *d) /* We won't need pci_dev if we switch to generic consistent * DMA routines ... */ - if (dev == NULL || pmif->dma_regs == 0) + if (!dev || pmif->dma_regs) return -ENODEV; /* * Allocate space for the DBDMA commands. -- 1.8.3.1