Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: Fix a double free in myrs_cleanup
To:     Lv Yunlong <lyl2019@mail.ustc.edu.cn>, hare@kernel.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210311063005.9963-1-lyl2019@mail.ustc.edu.cn>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <0e841bdd-9903-8e69-b2a0-89e702118c14@suse.de>
Date:   Thu, 11 Mar 2021 11:43:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210311063005.9963-1-lyl2019@mail.ustc.edu.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/11/21 7:30 AM, Lv Yunlong wrote:
> In myrs_cleanup, cs->mmio_base will be freed twice by
> iounmap().
> 
> Fixes: 77266186397c6 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
> ---
>  drivers/scsi/myrs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
> index 4adf9ded296a..329fd025c718 100644
> --- a/drivers/scsi/myrs.c
> +++ b/drivers/scsi/myrs.c
> @@ -2273,12 +2273,12 @@ static void myrs_cleanup(struct myrs_hba *cs)
>  	if (cs->mmio_base) {
>  		cs->disable_intr(cs);
>  		iounmap(cs->mmio_base);
> +		cs->mmio_base = NULL;
>  	}
>  	if (cs->irq)
>  		free_irq(cs->irq, cs);
>  	if (cs->io_addr)
>  		release_region(cs->io_addr, 0x80);
> -	iounmap(cs->mmio_base);
>  	pci_set_drvdata(pdev, NULL);
>  	pci_disable_device(pdev);
>  	scsi_host_put(cs->host);
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer