Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp301685pxf; Thu, 11 Mar 2021 04:22:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQbNOjnaDq/1dWG6URf1B9sGqAfpJT/uFz3ttfaqnb74HNag/rHVrrD/ER4969r1gSh/W1 X-Received: by 2002:aa7:d4ca:: with SMTP id t10mr8136195edr.388.1615465339265; Thu, 11 Mar 2021 04:22:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615465339; cv=none; d=google.com; s=arc-20160816; b=lOWfdPoX1Lv4lD3HdqUzMw8FRUCehos0Tivi4Cf+ul2oF37NGhhvgpv8lcMRHm7c/l Qu6b5rkbwukSJcz7DZMJnsX1DKGaa7T9t5VnCT3BrxpPQwLttwDZkoG/OSfUenZGYytF DmJS0jdt2IUDE7Rc3hK2Od8fWAHrXWeS5JWiGkY8jfX4TzGKmZlF4/r6Lrt5TGKghw71 yKxMkXXhK5lRg5yOvptTbSJKw3nx5/7FV7x96FFei5iN8eJayUHVAx8b32UbDRDaWhOo HOweYM2FrH5eT9uq9OJYOGtaca3WlcgT19auoOq0iwavHRVz/O09ys2PIOxeYnWki/K4 sh/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EYGFrEW02KUhIrzCGk6j2y1DSBi0VEvJiIGApiPKgfI=; b=e6wwoaDTqZKNlboyJmaP4czdnR/VId0uJiirkuBxZ7RjJhQrBtkDrgsLCSqK3h8Lia aYyLd3TCqJfAi+eMy1Z5Dpv/5K/ExyjKISFByuztTo1qPWSNqtQ37xQDlIq/eOmAXZkR f8E8Pz5weGqzO3GSL5jVxDC1GrtX41Lf4D/M3VZTLpqL+jY7E/I137s9Rbn/WGEDe7im +pbn1k3KgvZEDJH5UBX6Z5O0TgCaO2vhn4QONEJuM6Zv5YhcdY3MWNrKMlEpSx3N+WP2 rW0S4EE9M9qpE2XHq7bXBVoQ3Ly/ikJ2vIz89b8WuOrrH2h1IckF1J1uDeaEObzq8smW D4GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TyoGQkrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si1612938edd.547.2021.03.11.04.21.56; Thu, 11 Mar 2021 04:22:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TyoGQkrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232894AbhCKMU5 (ORCPT + 99 others); Thu, 11 Mar 2021 07:20:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbhCKMUo (ORCPT ); Thu, 11 Mar 2021 07:20:44 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67BA6C061760 for ; Thu, 11 Mar 2021 04:20:44 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id jt13so45869570ejb.0 for ; Thu, 11 Mar 2021 04:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EYGFrEW02KUhIrzCGk6j2y1DSBi0VEvJiIGApiPKgfI=; b=TyoGQkrwpHdv/lBARJpZfrijdU2O8+MCDuhgh5lx3pNzaKF8z3/1RIh3bbpQ8dvFV9 CWFbmvHewQd1NNb5IGRk/JBn2/4bTHHXKYYoMMyI2l++6uoCg+nmo60W6y8RFOzzvN1V WvuotfLz4U5ryDk7SNlIumi6A2y+ZCrSRcU3o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EYGFrEW02KUhIrzCGk6j2y1DSBi0VEvJiIGApiPKgfI=; b=lBlIXIZMhXVJ87jUgBQWLDwPN607WoefTr6lZljRweiiU0huhdA94Z/qvDdqDqyOhJ mvBSp6c4Bk+NhWN8WV+gPa34qK8jGxsst5uUuDbSOku/I4ZxowmInWHXi63iM04C6F2z PB0injS0Nx/SqcxxhWfVG626OLGixzvPtjd/JLEkZIgFFVvbJZJjE9NlS3O7xmRaLvYt PS8VsaAhLZc8k6kGViZzTDj+wrhWIwiP3q/f76Fwq7ft2uSqAXK7BO6doBmKu4iV1Mht clRtYX1PFKYRVXi3B3eL+Y/ZjPmZqKa0zQr9h3UoaxeBozh6NPD2OFBszuaMrbfYQ54W 7NiA== X-Gm-Message-State: AOAM532OP4pBx3r8OYESVn2P7wTDGlz2srNIZTl78y1AN9VcugSwwGVI SReD7vZ30DWAQLXdlZ9JZibe4Q== X-Received: by 2002:a17:907:2093:: with SMTP id pv19mr2851780ejb.134.1615465243068; Thu, 11 Mar 2021 04:20:43 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id u13sm1264126ejy.31.2021.03.11.04.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 04:20:42 -0800 (PST) From: Ricardo Ribalda To: Laurent Pinchart , Mauro Carvalho Chehab , Tomasz Figa , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, senozhatsky@chromium.org Cc: Ricardo Ribalda Subject: [PATCH 01/10] media: uvcvideo: Return -EINVAL for REQUEST API Date: Thu, 11 Mar 2021 13:20:30 +0100 Message-Id: <20210311122040.1264410-2-ribalda@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210311122040.1264410-1-ribalda@chromium.org> References: <20210311122040.1264410-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver does not support it. Fixes v4l2-compliance: Buffer ioctls (Input 0): fail: v4l2-test-buffers.cpp(1925): ret != EINVAL && ret != EBADR && ret != ENOTTY test Requests: FAIL Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 252136cc885c..5e3ec4a376e4 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1046,6 +1046,9 @@ static int uvc_ioctl_g_ext_ctrls(struct file *file, void *fh, unsigned int i; int ret; + if (ctrls->which == V4L2_CTRL_WHICH_REQUEST_VAL) + return -EINVAL; + if (ctrls->which == V4L2_CTRL_WHICH_DEF_VAL) { for (i = 0; i < ctrls->count; ++ctrl, ++i) { struct v4l2_queryctrl qc = { .id = ctrl->id }; -- 2.31.0.rc2.261.g7f71774620-goog