Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp301760pxf; Thu, 11 Mar 2021 04:22:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYERg7vFU1fxIURVGG4Ud8+zcLQGqKxEmOH9pKKzAX/aPxdNxGejDE8T6C7Vl9s5ZabpL0 X-Received: by 2002:a17:906:4e91:: with SMTP id v17mr2813337eju.331.1615465346315; Thu, 11 Mar 2021 04:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615465346; cv=none; d=google.com; s=arc-20160816; b=Z1n8iwhLhQM48T2NjeDMbwGOZjfdcYqvN+TjlZS9c2Vfa96PGHnuja8MwEO+XSXCUD wYyvjBYoXgy8sSPxl/xVi35eTRfnDrqpdc4zlAC8ot7xjZTslM5zjN8XzPCk4RJak8dd VJyZ4URw9S7ZtfB3sV9N2gjknonu2QoUKLer/PuZce+yqHl8pre9QFTZ6F03naOoJJBf a4mQB9/2inSY7xcp3OTSEt/GO3Ns/TtTTrbH/kOQPSeR3Mlnjf2tbtpRmby/pNCfILJ9 ifszgn1E6laQLsYlar0FMxB9bhNdil0Ig0N0qnN6e1EpuAdfnOTXbVK4KoqWar1tnGka MufA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Adt3VWd7Tr97xOkIDn3xdQPcPlfaPE3dZS8MA+RZVj8=; b=W61b8eiKyxuWOkT+v6IK80aSrPP3klozFDqlTPxCQ7T8vNMvqrPCiCpC3u6mG+ah82 2B9JehWvKYFHoVZ+k8wMpk5/zSRTxjNZAetvQG4EmYks7HA+Zks4kSF68M1TlA5keh0x V2hA8vpXkMP4GqUCgKjQxAMEDYv7oanSqmXjpPMX2/8yI3pOchp0spjgBJ1MB0Yxajxb gUp7bzFvtPAoQlCoX14y+XZgsIOWnqmwgUZWsSfnWvX+xfhqigqrcBDFZLqWkyJyeUjb xv3QZ6oS7i0E7kV+xQ6Jf1UWabBvTz9SWkSb4k9Px8AhkeuKciuuFnOqPlXHtXCRYP52 wrkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WHeLI+EZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si1630273ejd.256.2021.03.11.04.22.03; Thu, 11 Mar 2021 04:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WHeLI+EZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233131AbhCKMVC (ORCPT + 99 others); Thu, 11 Mar 2021 07:21:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbhCKMUq (ORCPT ); Thu, 11 Mar 2021 07:20:46 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 139BEC061761 for ; Thu, 11 Mar 2021 04:20:46 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id x21so2439239eds.4 for ; Thu, 11 Mar 2021 04:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Adt3VWd7Tr97xOkIDn3xdQPcPlfaPE3dZS8MA+RZVj8=; b=WHeLI+EZeWdnBLfu9US6qMqfpgSdFYoKlGy7DNd/hBlMkazrM0ZkVkMJhtB+Y9wBYy Cqx71vWATisDUPo/reydXXFvZv+wNnevjhLUNtQg/IIamfzNes1MWNg2+3cszxTOsvkC GyFIt+FhwbJdSYNve/ANvnB9WkuUwSysPVZso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Adt3VWd7Tr97xOkIDn3xdQPcPlfaPE3dZS8MA+RZVj8=; b=rVX88Jdy5whekxrOIkbhHBUFRm+3imavQzpIixnxn3hiHZaZNUqxxobHkFEhv6kfjm 1GWuEjIoJeFKX334GcbovgiUh0+2sM4yhM2HGagpxNZk51BccI242dHfol6KoGeex7nC qkF+rtjoOoOxTKTpzCOOI0AqD+kz2eP+gvATGSaoT6omSd2jmTEef3UVRV9NbVM4FQNy 7VP85CR0lJuDzpWC67St+N8dhhd/O+6Tg3VzKUhBRPBXS1eP03+ev2ie3wCFyI2Q71yb Z2LWLOMTLkr+Ehry4DSIAJy6kEWN2bBKCvFt7pSgTX9zUDYgxX7QWJdaw+aZrbUQVn/X VIFw== X-Gm-Message-State: AOAM532vNl/LViEcAVlVfgun8GSVWHJwMXACJbRj3obNeMKp5SpiO3TB I0Xw3SN1AM7/p4RIau6jgnI1jg== X-Received: by 2002:aa7:c0c7:: with SMTP id j7mr8195805edp.298.1615465244891; Thu, 11 Mar 2021 04:20:44 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id u13sm1264126ejy.31.2021.03.11.04.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 04:20:44 -0800 (PST) From: Ricardo Ribalda To: Laurent Pinchart , Mauro Carvalho Chehab , Tomasz Figa , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, senozhatsky@chromium.org Cc: Ricardo Ribalda Subject: [PATCH 03/10] media: uvcvideo: Return -EIO for control errors Date: Thu, 11 Mar 2021 13:20:33 +0100 Message-Id: <20210311122040.1264410-5-ribalda@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210311122040.1264410-1-ribalda@chromium.org> References: <20210311122040.1264410-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) test VIDIOC_G/S_CTRL: FAIL fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an error (22) test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index f2f565281e63..5442e9be1c55 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -113,7 +113,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, case 6: /* Invalid control */ case 7: /* Invalid Request */ case 8: /* Invalid value within range */ - return -EINVAL; + return -EIO; default: /* reserved or unknown */ break; } -- 2.31.0.rc2.261.g7f71774620-goog