Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 11 Mar 2021 06:18:34 +0100
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Rob Herring <robh@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells
 compatible
Message-ID: <YEmoKuL9IyIrUW0N@Ansuel-xps.localdomain>
References: <20210310210812.8880-1-ansuelsmth@gmail.com>
 <20210310210812.8880-2-ansuelsmth@gmail.com>
 <5d798266-3a18-d50d-9c3e-f91bc2460fe5@gmail.com>
 <YElMjg/AspNSRe0A@Ansuel-xps.localdomain>
 <1d2ad735-ad15-be6a-ad90-9c33f5845a15@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1d2ad735-ad15-be6a-ad90-9c33f5845a15@gmail.com>
Precedence: bulk

On Thu, Mar 11, 2021 at 07:37:13AM +0100, Rafał Miłecki wrote:
> On 10.03.2021 23:47, Ansuel Smith wrote:
> > On Wed, Mar 10, 2021 at 11:41:24PM +0100, Rafał Miłecki wrote:
> > > See inline
> > > 
> > > On 10.03.2021 22:08, Ansuel Smith wrote:
> > > > Document nvmem-cells compatible used to treat mtd partitions as a
> > > > nvmem provider.
> > > > 
> > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > > > ---
> > > >    .../bindings/mtd/partitions/nvmem-cells.yaml  | 96 +++++++++++++++++++
> > > >    1 file changed, 96 insertions(+)
> > > >    create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > > > new file mode 100644
> > > > index 000000000000..f70d7597a6b0
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > > > @@ -0,0 +1,96 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Nvmem cells
> > > > +
> > > > +description: |
> > > > +  Any partition containing the compatible "nvmem-cells" will register as a
> > > > +  nvmem provider.
> > > > +  Each direct subnodes represents a nvmem cell following the nvmem binding.
> > > > +  Nvmem binding to declare nvmem-cells can be found in:
> > > > +  Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > +
> > > > +maintainers:
> > > > +  - Ansuel Smith <ansuelsmth@gmail.com>
> > > 
> > > I think that when Rob wrote:
> > > 
> > > On 10.03.2021 03:58, Rob Herring wrote:
> > > > I think this should reference nvmem.yaml.
> > > 
> > > he meant you using:
> > > 
> > > allOf:
> > >    - $ref: "nvmem.yaml#"
> > > 
> > > (you'll need to adjust binding path).
> > > 
> > > Please check how it's done in Documentation/devicetree/bindings/nvmem/*.yaml files
> > > 
> > > 
> > 
> > Aside from that, should I readd the old properties or I can keep the
> > compatible as the only one required?
> 
> What old properties do you mean?
> 
> You shouldn't need to add anything to the list of "required" I think.
> 
> Some NVMEM providers add "#address-cells" and "#size-cells". That makes
> sense if NVMEM provider must provide at least 1 cell. I'm not sure if we
> need that for MTD.
> 
> Even "compatible" is actually redundant but most YAML files list it for
> convenience. Source:
>

Thanks for the clarification, I sent the new version hoping the yaml
documentation is now correct.

> On 10.12.2020 03:48, Rob Herring wrote:
> > And drop 'compatible' as required. It's redundant anyways because the
> > schema will only be applied if compatible matches.
> 
> http://lists.infradead.org/pipermail/linux-mtd/2020-December/084574.html
> https://patchwork.ozlabs.org/comment/2597326/