Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp307664pxf; Thu, 11 Mar 2021 04:31:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGPfBrTHRmLn2iohZw8ki9y4MsZ6nyj9KnqSlyG0uipstRRTvZUmZVFxcMw6t9vLwWKaoV X-Received: by 2002:a17:906:b286:: with SMTP id q6mr2907656ejz.422.1615465914319; Thu, 11 Mar 2021 04:31:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615465914; cv=none; d=google.com; s=arc-20160816; b=JK0cvVl/YX8M/QRvjFflxFasCFtkvpNEBGm8g0/l/3rmTgU00zlCyWrjDC089EijzM EbmhTvd7BKwewlw14VjMLPB2MOglv27IhrN0GGlsFDXGjhnfnVYNby3lrIF2kCGOOtVZ eDdZrs2Mar1wQgiU8SbhU/lD+V7lmMBNe/hw92H1LfekKLeL2FRcQ6/XvZpt7cODVyep FUOZz5wjFihWRcsbNpeeI8+NqAafKilKIrUW71zUx8zfUB0vKADpRad83yLy0HECxTjC PaIjTfntVqOqNZHshu273Ln+5tdrdxym5NHVSCyvrr1n2FIchtSvdSwIr+3Set2ntBXP 0J3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dACKxyoSh3EwXe5OhLq5kiNpUUcGz+ifPQW3+5fGDME=; b=k48Ek2bhGWWjZFY9QcL3/lDQ1JhSU7EZ0sqYBnRvohxQvMVd9nPhmpSZDHZfJuIq/V 39HaXgSSoxl+Ec57/1qVSnpw2/6S5aoPabKWFsqi3zaIdjVCajgZsxzL+t+E3fQ/3Zlm O9jjT47f03hiDDtKe3NzwkzGLpADOLiLYAma8ECbcONhLJF99MgqLNuqLq/b+Y1lIZqV 1Odip1yGekKGfPFuum4cAkTRIBeQzLPeZFFGzAqUGnp491hL6SweewmjFZuO29vQEq6g lP/kgC7hpSjyuFHFgdJH9xevoG5TGSTzrBfeEceBD8R4i82dj1xEpB/bcTNThSef443z G6Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q16si1869499edr.239.2021.03.11.04.31.31; Thu, 11 Mar 2021 04:31:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233075AbhCKMae (ORCPT + 99 others); Thu, 11 Mar 2021 07:30:34 -0500 Received: from verein.lst.de ([213.95.11.211]:40787 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233084AbhCKMaJ (ORCPT ); Thu, 11 Mar 2021 07:30:09 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 98CCA68B05; Thu, 11 Mar 2021 13:30:03 +0100 (CET) Date: Thu, 11 Mar 2021 13:30:02 +0100 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, darrick.wong@oracle.com, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, david@fromorbit.com, hch@lst.de, rgoldwyn@suse.de Subject: Re: [RESEND PATCH v2.1 07/10] iomap: Introduce iomap_apply2() for operations on two files Message-ID: <20210311123002.GA18838@lst.de> References: <20210226002030.653855-8-ruansy.fnst@fujitsu.com> <20210304054142.1147895-1-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304054142.1147895-1-ruansy.fnst@fujitsu.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 01:41:42PM +0800, Shiyang Ruan wrote: > Some operations, such as comparing a range of data in two files under > fsdax mode, requires nested iomap_open()/iomap_end() on two file. Thus, > we introduce iomap_apply2() to accept arguments from two files and > iomap_actor2_t for actions on two files. I still wonder if adding the iter based iomap API that willy proposed would be a better fit here. In that case we might not even need a special API for the double iteration.