Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: j5rnmEWxdYfscKoQWBNQv/yPmvssziPkS4AMX2OAZ+xFvlwMF8zpT4eionkptcY0ZdKMPP9iGp
 KFHCpLJNKYpw==
IronPort-SDR: xB56w9PhDRnuDJ7f4Gg+yUIN1KI6NhLjx7ddXPmme6K+6CnoR3ZXXNPFSsBVclTvTijXxh3Le8
 ZHKshZq4ZIKw==
Date:   Thu, 11 Mar 2021 15:33:36 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Badhri Jagan Sridharan <badhri@google.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kyle Tso <kyletso@google.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] usb: typec: tcpci_maxim: configure charging & data
 paths
Message-ID: <YEocMN1aSdDZ2dl/@kuha.fi.intel.com>
References: <20210311100313.3591254-1-badhri@google.com>
 <20210311100313.3591254-3-badhri@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210311100313.3591254-3-badhri@google.com>
Precedence: bulk

Hi,

On Thu, Mar 11, 2021 at 02:03:12AM -0800, Badhri Jagan Sridharan wrote:
> This change allows the driver to configure input current/voltage
> limit for the charging path. The driver sets current_max and voltage_max
> values of the power supply identified through chg-psy-name.
> 
> The change also exposes the data_role and the orientation as a extcon
> interface for configuring the USB data controller.

This looks wrong to me. Why wouldn't you just register your device as
a separate psy that supplies your charger (which is also a psy, right)?

thanks,

-- 
heikki