Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 11 Mar 2021 15:27:59 +0100
Message-ID: <s5hk0qdvk7k.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries.
In-Reply-To: <CAHp75VfdsOMpskK0xq7tAo1DJ21MPMxmFb1st--0vHJ6C+Nb6Q@mail.gmail.com>
References: <20210311132741.80989-1-andriy.shevchenko@linux.intel.com>
        <s5hpn05vmhm.wl-tiwai@suse.de>
        <CAHp75VfdsOMpskK0xq7tAo1DJ21MPMxmFb1st--0vHJ6C+Nb6Q@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 11 Mar 2021 15:22:22 +0100,
Andy Shevchenko wrote:
> 
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai <tiwai@suse.de> wrote:
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > > No functional change implied.
> >
> > I'd love to apply this kind of cleanups (and I do sometimes
> > partially), but practically seen, this may make the stable backporting
> > significantly harder because many quirk patches are backported to the
> > very old LTS kernels.  So, unless any specific reason (e.g. some
> > entries doubled or wrongly applied) is given, I'd avoid this full
> > plastic surgery.
> 
> Btw, can we apply the hunks that are against the lines under #if 0?
> At least it will reduce the chaos rate in the file w/o worrying that
> people will add entries there to backport.

If the #if-0-block causes a problem, we can drop it, too.  There are
two big ones, and those have been disabled for almost a decade
already, so it's quite safe to drop them.


Takashi