Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 11 Mar 2021 16:15:23 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tomer Maimon <tmaimon77@gmail.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        devicetree <devicetree@vger.kernel.org>,
        Avi Fishman <avifishman70@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 RESEND 2/2] ARM: dts: Add board-specific compatible
 string to npcm750-evb devicetree
Message-ID: <YEo0CynZ5X8tMylL@latitude>
References: <20210303154622.3018839-1-j.neuschaefer@gmx.net>
 <20210303154622.3018839-2-j.neuschaefer@gmx.net>
 <CAP6Zq1hwp+wJpbN496096q8izRRoU2Jg+OKugcSk+BcXWfME9A@mail.gmail.com>
 <YED/zzV5kb35k2vb@latitude>
 <CAP6Zq1h5QK0_3gBek3QNN_cb6tGFJJXU_D8UPJOqnaDbsQAkxw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="boiCNNVZ39FMb+0t"
Content-Disposition: inline
In-Reply-To: <CAP6Zq1h5QK0_3gBek3QNN_cb6tGFJJXU_D8UPJOqnaDbsQAkxw@mail.gmail.com>
Precedence: bulk


--boiCNNVZ39FMb+0t
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tomer,

your in-line reply got lost in the "> " lines, but I found it anyway.

On Thu, Mar 11, 2021 at 04:11:59PM +0200, Tomer Maimon wrote:
> Hi Jonathan,
>=20
> Thanks a lot for your effort!
>=20
> On Thu, 4 Mar 2021 at 17:42, Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.=
net>
> wrote:
>=20
> > On Thu, Mar 04, 2021 at 05:21:36PM +0200, Tomer Maimon wrote:
> > > Hi Jonathan,
> > >
> > > Thanks a lot for sending the patch,
> > >
> > > I think that when it related to the SoC EVB it can stay with the
> > > genral compatible name nuvoton,npcm750
> > >
> > > you can see it also in,
> > > https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/aspee=
d-ast2500-evb.dts#L8
> >
> > To make the single compatible string match the DT binding, I'll have to
> > write the binding a little differently. I wrote it like this:
> >
> >   compatible:
> >     oneOf:
> >       - description: NPCM750 based boards
> >         items:
> >           - enum:
> >               - nuvoton,npcm750-evb         # NPCM750 evaluation board
> >           - const: nuvoton,npcm750
> >
>
> I think it should be like the exemple above

If I specify the devicetree binding like above (which I initially did),
it implies that the compatible line in nuvoton-npcm750-evb.dts should be

	compatible =3D "nuvoton,npcm750-evb", "nuvoton,npcm750";

not

	compatible =3D "nuvoton,npcm750";


This is why I suggested rewriting it like below:

> >   compatible:
> >     oneOf:
> >       - description: NPCM750 development board
> >         const: nuvoton,npcm750
> >
> >       - description: NPCM750 based boards
> >         items:
> >           - enum:
> >               - vendor,foo-bar-bmc
> >           - const: nuvoton,npcm750


I will send this new approach as a patch in a few days.


Thanks,
Jonathan Neusch=C3=A4fer

--boiCNNVZ39FMb+0t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmBKNAMACgkQCDBEmo7z
X9tVqw//d78aQEHzqrMmTFjpknPfzV0jICAFnC3gHY5Fz+YK4Ff47meK8UDdxmrv
SHZbL4OoQfqxKRWICSMklYLNp1igbJ7wtr5r5c5yog7Vc80ToGQRyG4d06wdYl5Z
cjj8kQcNiKiqiCdAJXrzDdZHXePfmd4CjZok1zHC6rrYrBMjrMYEdAnUU+9JTfU8
gB0/Gt4cPyurybY62bgTF1s4WWHqdmFuBt4ZNL2H983jDdgEgI7vZOtoneBTarpM
XIUkCXv1jdxuRqs+G8Ln4liO/C2xyn7VrnVzdhdMohIaZ+CeE8z2iUoa+pktBwHM
+jIEg5EjZ9CjrQGa2t4DvL8PcSUSLVmwPetjiRJ0b76KQhVsUP6HvRyKOlGKF4Q3
V7rrjCSW70m7mZl5pokQRU2AcpGSWtkoJ7XxfMLFJE7Bdzsn278nRUo5IGr38M/r
9yCpVtc+E9DlpUPDavyJIEMn1R7q+fPM7Y/Sdks1hGTO+EiqzuUReH6ilzF2TIQo
pPBkoNdvDwfwA4DzCcZiz3vjPpG90T0hLqaZv00J7HBvcvnGz54jvFyJqqagAfbB
ZWRtBra4l5XtW84+FGo0nOVwRik45F0pwsui0tFzsqLPDvLhX0XW2upsFXZnUOBz
Vzy8RZw3uhbIEDogQx1vUof2AyAUUWjdE/1LA2aw7ZTyNxF3Jq4=
=7rtB
-----END PGP SIGNATURE-----

--boiCNNVZ39FMb+0t--