Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp445182pxf; Thu, 11 Mar 2021 07:22:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7z/TXwMIi1HYTHhKyjHnv3v/dnnKTswWSFgrhys4OiR3XcyNgDBvjABIa+xiIBC8YOQCK X-Received: by 2002:a50:9ea4:: with SMTP id a33mr9285045edf.295.1615476159559; Thu, 11 Mar 2021 07:22:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615476159; cv=none; d=google.com; s=arc-20160816; b=P6uPjm5x9oNPFvzQJEJYGZ3rYy3Qtmw2pW/nXSqh80k4ZqxyZHukyPtpBHspjRnXkv 72gjajoAP4ulfBbUOEUjsTxu8tFQTDeAY+Z5VbI0h9UwAzAK77PtXzAM3m1nz3HqtEqe 7tCpU9Q2RAuYcnxgrOf/gFsC1x9ZevJbIOTCol8amvIeHNtQLRsrPFkq+mb8c6sCGg3F oxS6vJAw4/8KXt0GRlJZThIS6rppKXlIsRB8/f9dMUHPC/SqT0FGxo3G27YUp4l7EwkG 3W1/MGynGOtPs7Z8brZmUlmOCqpQ8fdcXPu6wXET3aLQZ7c7gz14lvgcA+bsASoZ4khY 0T/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7J7yaJFOnkfC2jtN1RmZbpvdpvHIQ8OR5yg9sAgfaPM=; b=fpECNFMmUrhsRiOPpNUfK89b76IE7tnW2junfYcCVB/gDcqPR4b2mMZGh5dGF4Vw1d LTlDVDzlPmIJaiwyX9cVCw2q4FibLe6324dfExLOTVIx8SlEz3eBpwKBR72C8bvfmJjr uNQxQrEE0aFXMvgUUV0NxHtLPCEgcQXaQChVDFLRhwPqDUgffx31B3iDf0GcEvdIsxAd BEKBYsAGtCG/EYZ8gYpi73l34BPeels1iLs4mdcKe6tBt7xAvl8nuO6aVpW+DlcClusQ McfvuRlY5s7kB7o5HP1cQey7o7uCwQfdOUB85YocevgostR1fFm8gGA3kO33oLbMrYri Fipw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rqdZfM3e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p26si1882674edt.29.2021.03.11.07.22.16; Thu, 11 Mar 2021 07:22:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rqdZfM3e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234087AbhCKPVG (ORCPT + 99 others); Thu, 11 Mar 2021 10:21:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234028AbhCKPUs (ORCPT ); Thu, 11 Mar 2021 10:20:48 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D07DBC061574; Thu, 11 Mar 2021 07:20:47 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id n16so40413324lfb.4; Thu, 11 Mar 2021 07:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7J7yaJFOnkfC2jtN1RmZbpvdpvHIQ8OR5yg9sAgfaPM=; b=rqdZfM3eR9k+ZhKgG1OoSVc0CaH34cPPElYt0iXTLmPyW1GgRql2TEQY01o5ePEA07 DDxZmYNpzMZwmqINBPStZoEu/VobZXcOuMFoHKg7qbaROOu+zRQH+O71MUF7j8X0FyWW o4vs20xCRgkK6TDY8u+IkWo/0jZphQWSxKwuNsMmULL/alrjAf4zO5+kTvNH0ziHggc3 /cUMFw+wBEVfpMTfF8KQnvl/NWsVJ52xURnL1UKXD+TsVKU/W7BiociBSjN4GD9ZQPeV fburWken87QqPgOoBnEcE7sP5uTRjnfPBQUsiSb9eQxYfTliPO2sIX4WFn6Z0n1FQY+z ZJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7J7yaJFOnkfC2jtN1RmZbpvdpvHIQ8OR5yg9sAgfaPM=; b=BdKOkV/NRH6zHv774LNkzQkBRSnm+Gyr/9Yi8vj8+cnmvp+rlfolNLHSWpzv4Tky+R f8pPMTGj8RikOC5RimZFQ8eg5YXNoA7zVRfU/MCmNvEJTYl7T7CC80GEYqvBzG7R3r3L UODt1qcsnv6YoQ/kVST0tNqhqpCzVsTPCT9GYCUSX+s4udLnf+f+XIcqzFDTQ13z1H9/ SIOHEn/OtSg143h1TqJtaKr4ipSz0y+y0CcsG/lb2gSWr+F6qlgtI7lYKHkYT5nUdqPc YGzn/5R2ztWcuXTPSIRNGYrauMy4xctvgbUkAVRk5gLxhJL7wyD4+VxsWStdPlxAiC93 sC2Q== X-Gm-Message-State: AOAM530b8lSc8Mfs3aEsGAPoGN4VkJ3i+L/uoqAN4JaY/q4y95k8qB5X Muh4A8wSdUIr2VTrtJjiREYXx8tdidGkfYQLxHU= X-Received: by 2002:a19:b47:: with SMTP id 68mr2463159lfl.343.1615476046303; Thu, 11 Mar 2021 07:20:46 -0800 (PST) Received: from localhost.localdomain ([94.103.235.87]) by smtp.gmail.com with ESMTPSA id 30sm929562lfr.200.2021.03.11.07.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 07:20:45 -0800 (PST) From: Pavel Skripkin To: hverkuil@xs4all.nl, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Skripkin , syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com Subject: [PATCH] media: usb: fix uninit-value in sq905_read_data Date: Thu, 11 Mar 2021 18:20:16 +0300 Message-Id: <20210311152016.171506-1-paskripkin@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sybot reported uninit value in sq905_read_data(). The problem was in the error conditions in usb_bulk_msg() before act_len initialization. Reported-by: syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin --- drivers/media/usb/gspca/sq905.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/sq905.c b/drivers/media/usb/gspca/sq905.c index 97799cfb832e..949111070971 100644 --- a/drivers/media/usb/gspca/sq905.c +++ b/drivers/media/usb/gspca/sq905.c @@ -158,7 +158,7 @@ static int sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock) { int ret; - int act_len; + int act_len = 0; gspca_dev->usb_buf[0] = '\0'; if (need_lock) -- 2.25.1