Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp480326pxf; Thu, 11 Mar 2021 08:00:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDxpMqVuRD05WJ+eE9GJ5wBM6TjpzSoyVYO59Ho9F7bkA0ZL0TpyJd+VjsJTaqq3aC0o4x X-Received: by 2002:a50:fe08:: with SMTP id f8mr9094747edt.217.1615478412262; Thu, 11 Mar 2021 08:00:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615478412; cv=none; d=google.com; s=arc-20160816; b=CGADxPQOMVUMPBC9NMG97xeFfaC/QOUdFjia1X1gHYR4qB76sYe1ePdmEs802eYXe8 g3y+4u8YnSGYQd3+y0BN7NxhViDehC/3dhR4GkawCXNoJnLVoWk0ta/Aqr9uVxUlPUI/ dVnXGAdTWHv5nAsGDiHNBSLjaCmlDmAKPzTgpriq81xjNZvGef+ewoE0i8GVBSlG42h4 23Rp2RyJYsjGMNSjo6IshoZseSFy3eQrCJpux5O9Pjryy95Q/kE5C0VShu1gbGYWq8RU ssaugKBEyJimHlattStgJvVY4SCcBismZNR3++mRBSpKvbxs8LBr/CUS2isSe6KTIp94 SIAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=6KPA7n25JfxihkvBOuNqMiF+PrCY08hCHx6L0dSTPUA=; b=W8slQFXjYs5wSx6+T/SexDiOOC3qj2YhX+fu7mm2WFTqz9RpuElCGV7JseX2ZUXem4 mO9gT+VwyMVs4VDI9ePj2n4bq8RFPD5UthcM1WwNXY6zj6T0egeUxvWq134EXH86kJGJ tEeeYIeRUeqbDf4Ccrkr7Z9wbD962dttxOC9rsiiz/AbU7SUCWrxlE8Yy98Tr27lNNah IJRk5q4Z/8Lw9fY8WvopkL33K0bvZRf7fTqrjQ8UM2PVxEudnHeE9o/e7rqIpdOXkPoW Vj+retHvxNBcChfm0z0fGBK+7lP8jMAs3rWFfglsbaQgVLcsvowbusyRa+mWtDKCS/Vd INjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w26si1914247eju.454.2021.03.11.07.59.47; Thu, 11 Mar 2021 08:00:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234236AbhCKP6V (ORCPT + 99 others); Thu, 11 Mar 2021 10:58:21 -0500 Received: from mga01.intel.com ([192.55.52.88]:18629 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234018AbhCKP5t (ORCPT ); Thu, 11 Mar 2021 10:57:49 -0500 IronPort-SDR: JzTy6vn+hG5vaC4mr1HVVV604SM6XhXKbjNhC146mduXX/jZgaWM4jH/pLxt4o0qlcMtExVTJp Vfud35QEJK6A== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="208512589" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="208512589" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 07:57:49 -0800 IronPort-SDR: T9NgBxuLmQfyVoP+1uuu+kXqcqghmZvmA2pZZKMD3+0o8z+KHEVHi5/XqOj01MWt1m8iaVa1Zi 7M56Mx/ejamA== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="410650575" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 07:57:49 -0800 Date: Thu, 11 Mar 2021 07:57:48 -0800 From: Ira Weiny To: Andrew Morton , David Sterba Cc: Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] btrfs: Convert kmap/memset/kunmap to memzero_user() Message-ID: <20210311155748.GR3014244@iweiny-DESK2.sc.intel.com> References: <20210309212137.2610186-1-ira.weiny@intel.com> <20210310155836.7d63604e28d746ef493c1882@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310155836.7d63604e28d746ef493c1882@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 03:58:36PM -0800, Andrew Morton wrote: > On Tue, 9 Mar 2021 13:21:34 -0800 ira.weiny@intel.com wrote: > > > Previously this was submitted to convert to zero_user()[1]. zero_user() is not > > the same as memzero_user() and in fact some zero_user() calls may be better off > > as memzero_user(). Regardless it was incorrect to convert btrfs to > > zero_user(). > > > > This series corrects this by lifting memzero_user(), converting it to > > kmap_local_page(), and then using it in btrfs. > > This impacts btrfs more than MM. I suggest the btrfs developers grab > it, with my I thought David wanted you to take these this time? "I can play the messenger again but now it seems a round of review is needed and with some testing it'll be possible in some -rc. At that point you may take the patches via the mm tree, unless Linus is ok with a late pull." -- https://lore.kernel.org/lkml/20210224123049.GX1993@twin.jikos.cz/ But reading that again I'm not sure what he meant. David? Ira > > Acked-by: Andrew Morton >