Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965230AbWJCE6s (ORCPT ); Tue, 3 Oct 2006 00:58:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965243AbWJCE6s (ORCPT ); Tue, 3 Oct 2006 00:58:48 -0400 Received: from smtp.osdl.org ([65.172.181.4]:13026 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965230AbWJCE6r (ORCPT ); Tue, 3 Oct 2006 00:58:47 -0400 Date: Mon, 2 Oct 2006 21:55:27 -0700 From: Andrew Morton To: Benjamin Herrenschmidt Cc: Judith Lebzelter , linuxppc-dev@ozlabs.org, Linux Kernel list , Adrian Bunk Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Message-Id: <20061002215527.096a8762.akpm@osdl.org> In-Reply-To: <1159850979.5482.40.camel@localhost.localdomain> References: <20061002214954.GD665@shell0.pdx.osdl.net> <20061002234428.GE3278@stusta.de> <20061003012241.GF3278@stusta.de> <1159850245.5482.32.camel@localhost.localdomain> <20061002214400.0a83b743.akpm@osdl.org> <1159850979.5482.40.camel@localhost.localdomain> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 34 On Tue, 03 Oct 2006 14:49:39 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote: > > On Tue, 03 Oct 2006 14:37:25 +1000 > > Benjamin Herrenschmidt wrote: > > > > > > > You might want to convince Andrew accepting my patch to make > > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making > > > > > people more aware of this problem... > > > > >... > > > > > > Andrew, is there any reason not to take that patch ? > > > > It generates lots of warnings from drivers which nobody does any work on. > > > > Net result: lots of new warnings, no fixed bugs. > > Are you sure the warnings won't cause somebody like Al to go through > them all and fix them ? The drivers simply don't link on some architectures, due to missing virt_to_bus/bus_to_virt. They aren't hard to find. > At least they should be marked either CONFIG_BROKEN or X86 only (or > whatever arch they are supposed to be used on). > Something like that would make sense. I guess a new config option. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/