Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: dgilbert@interlog.com
Subject: Re: [PATCH][next] scsi: sg: Fix use of pointer sfp after it has been
 kfree'd
To:     Colin King <colin.king@canonical.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210311103717.7523-1-colin.king@canonical.com>
From:   Douglas Gilbert <dgilbert@interlog.com>
Message-ID: <a1e80cea-a1b3-9471-8022-2e25eb6c635c@interlog.com>
Date:   Thu, 11 Mar 2021 12:17:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210311103717.7523-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-03-11 5:37 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently SG_LOG is referencing sfp after it has been kfree'd which
> is probably a bad thing to do. Fix this by kfree'ing sfp after
> SG_LOG.
> 
> Addresses-Coverity: ("Use after free")
> Fixes: af1fc95db445 ("scsi: sg: Replace rq array with xarray")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Douglas Gilbert <dgilbert@interlog.com>

Thanks.

> ---
>   drivers/scsi/sg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 2d4bbc1a1727..79f05afa4407 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -3799,10 +3799,10 @@ sg_add_sfp(struct sg_device *sdp)
>   	if (rbuf_len > 0) {
>   		srp = sg_build_reserve(sfp, rbuf_len);
>   		if (IS_ERR(srp)) {
> -			kfree(sfp);
>   			err = PTR_ERR(srp);
>   			SG_LOG(1, sfp, "%s: build reserve err=%ld\n", __func__,
>   			       -err);
> +			kfree(sfp);
>   			return ERR_PTR(err);
>   		}
>   		if (srp->sgat_h.buflen < rbuf_len) {
>