Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp574201pxf; Thu, 11 Mar 2021 09:43:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOEz3KfkpeiCNKpcl++TYn+cfluvHHcTyC0Jd/Sksepjpgkdapq08Um2tVPziqHvfNcSTa X-Received: by 2002:aa7:d4cb:: with SMTP id t11mr9576444edr.202.1615484621235; Thu, 11 Mar 2021 09:43:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615484621; cv=none; d=google.com; s=arc-20160816; b=T15TidTFNHJENyyeVvcqAh7PlPdPWIsF0o0aXQ20rv+zL0NwquK7G5SKuhERKCqH8h 2LTFtGTyhFbJpdR0gWhbFD9SLrWLUhp6oxwZ28yhd5LNpTgJxeSJKPMNlsjQszd8Mx+P Vidt7r4L+2776zpREkHGzjxGWE15Zkii0RUqR7O+CCtf3lGV6fSM+0GuplJREl1DDBoX sMVojTPWbNogmA27noqVnEbIr9PMZXymdxeB1gFCgRRhJmpC1eGdOG10gIL3Bh3vyKIz e0tim2RtgvqAD4UKDC8L3OKYR7nWj9LWWCpgju1/xIxlSY/CoGgT9vh7zNIlXdSwfOdh tR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=0f8lDo3OvPRJSN+ZFB/dC5IZVLZhwgxRNo7PNoTfAgY=; b=qXbWaR631cY+XOa5Wp1Kl6kWDFCIyfGwlWnVqlIkLEZdVqbY3jmVNZkmQxydAmz69/ EfXQLgIhT7H6xhfUFszEtzvveeVTvOf7XCsV3HRIQf/bJ7MbApfvAC622ccvGvZrc3QN TUWBRtfg/GlnD70wqy8p/NjIGpcDX0nm1mUUggtPy1lXjSM3LleIy8ABGazNVbTLmVEo CBbh/PxTucFs36T/UJoYjkkBdwbhoSNduDoqxpSayYwWjsQhnnmSh/xX8a9TWS5mXAXQ KQ9E1E5UfwT6pliw510qVTzijzcgHa52GF36zUPgbp9oe3bh2Pk94RQlJKhs4Kj7eoQf UEBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si2239518edv.23.2021.03.11.09.43.16; Thu, 11 Mar 2021 09:43:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhCKRl5 (ORCPT + 99 others); Thu, 11 Mar 2021 12:41:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52380 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhCKRlt (ORCPT ); Thu, 11 Mar 2021 12:41:49 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKPJc-00AOPZ-Fp; Thu, 11 Mar 2021 18:41:40 +0100 Date: Thu, 11 Mar 2021 18:41:40 +0100 From: Andrew Lunn To: Ilya Lipnitskiy Cc: Sean Wang , Landen Chao , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next,v2 1/3] net: dsa: mt7530: setup core clock even in TRGMII mode Message-ID: References: <20210311020954.842341-1-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311020954.842341-1-ilya.lipnitskiy@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 06:09:52PM -0800, Ilya Lipnitskiy wrote: > A recent change to MIPS ralink reset logic made it so mt7530 actually > resets the switch on platforms such as mt7621 (where bit 2 is the reset > line for the switch). That exposed an issue where the switch would not > function properly in TRGMII mode after a reset. > > Reconfigure core clock in TRGMII mode to fix the issue. > > Tested on Ubiquiti ER-X (MT7621) with TRGMII mode enabled. Please don't submit the same patch to net and net-next. Anything which is accepted into net, will get merged into net-next about a week later. If your other two patches depend on this patch, you need to wait for the merge to happen, then submit them. Andrew