Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 11 Mar 2021 19:02:25 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Hermes Zhang <chenhui.zhang@axis.com>
Cc:     Dan Murphy <dmurphy@ti.com>, kernel@axis.com,
        Hermes Zhang <chenhuiz@axis.com>, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver
Message-ID: <20210311180225.GA11650@duo.ucw.cz>
References: <20210311130408.10820-1-chenhui.zhang@axis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF"
Content-Disposition: inline
In-Reply-To: <20210311130408.10820-1-chenhui.zhang@axis.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> +	priv =3D devm_kzalloc(dev, sizeof(struct gpio_dual_leds_priv), GFP_KERN=
EL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	priv->low_gpio =3D devm_gpiod_get(dev, "low", GPIOD_OUT_LOW);
> +	ret =3D PTR_ERR_OR_ZERO(priv->low_gpio);
> +	if (ret) {
> +		dev_err(dev, "cannot get low-gpios %d\n", ret);
> +		return ret;
> +	}
> +
> +	priv->high_gpio =3D devm_gpiod_get(dev, "high", GPIOD_OUT_LOW);
> +	ret =3D PTR_ERR_OR_ZERO(priv->high_gpio);
> +	if (ret) {
> +		dev_err(dev, "cannot get high-gpios %d\n", ret);
> +		return ret;
> +	}

Actually... I'd call it led-0 and led-1 or something. Someone may/will
come with 4-bit GPIO LED one day, and it would be cool if this could
be used with minimal effort.

Calling it multi_led in the driver/bindings would bnot be bad, either.

Best regards,
								Pavel
--=20
http://www.livejournal.com/~pavelmachek

--h31gzZEtNLTqOjlF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYEpbMQAKCRAw5/Bqldv6
8jqjAKCWcWAkZNGGAxNOIktK1uCe6A8zRQCgjkpPZ+LbgMY8O6aNtfahC4gUE60=
=5aO+
-----END PGP SIGNATURE-----

--h31gzZEtNLTqOjlF--