Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp701470pxf; Thu, 11 Mar 2021 12:43:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLboacy7QYLv/WmblAbuwU/1o3Jb3f0pbPf66R+MPa9zBXFHrvHh7gqmiJwN6gTYp7J02y X-Received: by 2002:a17:906:81c9:: with SMTP id e9mr4811470ejx.456.1615495399928; Thu, 11 Mar 2021 12:43:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615495399; cv=none; d=google.com; s=arc-20160816; b=alynlp9UgGoe5oxCNwmIBV6V2p21uBFA3N3jXuxlcs/Go2Uxd3DbVWpufYQ1jY+45j G6y23iEqDPasOQEv7z/h84Ry4c3VCDyusY0Ry9jvyo+wO7ZIgKis5/+S9gB7wXXjbnHI qtRQedmCxJXrqhh+WOSMjfwyzsJvtu+DWeU/ZEv9RDSvRBirYnUlLYika9k1zLs5x/UQ K8nabiYgsuEohMLac9362wLkQqgLIhCTPg946auW5zEWZqppQ2rgIAEUTEzhwq1hIsbX eCDB74aK7jrpphrNg51xV3rwWuMu+BPAbKl6XLLcTgdEU8BC96XYLaWho7pIlh4/ilTv V6fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=5oS6J+VnN6oIwM7KnZIqVwneChmPJzUhqFewjHyai6Q=; b=OMWEn1OkP8nme9VgreLzbHA7QR7/xIL2KPP+Cm0/QLbgo6ep4VST23cF4N4CWerwAI VXW/RNlJfZ+5e4NnYPwiL/8OA08kbE5rLRpqBLSVbZ8qzHupC1icNNnlqvKTMBW5ZysK K9fjM7YtrBwvJt6OohSLOiBjt0UfSJz1Zo7zgavHCybSRSTu77dBUbEaTxnIJzyZh4u5 g3l/fqdvS6xgC1SXlrnLSupOu4Tp8y9l44UvObo0pMnLm/8+lMD2fGle2rjen4sL+/re ktw+B5lmZIh2xTPU/ItCc4h229Gvlrm+ZaOI6FCSr1lMDxGO1DIsg3sCEGjMfCnQ15Ft shkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tiJgX7en; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg8si2458018ejc.657.2021.03.11.12.42.57; Thu, 11 Mar 2021 12:43:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tiJgX7en; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbhCKUjV (ORCPT + 99 others); Thu, 11 Mar 2021 15:39:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:53794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbhCKUit (ORCPT ); Thu, 11 Mar 2021 15:38:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 02FAA64F87; Thu, 11 Mar 2021 20:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615495129; bh=8qk+t4Se0OgXakD2pLBQ6PuuOIhC1+z3sY3KxjsZ2iA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tiJgX7enU7AVwQZk8qoVZjyvvExd/IRN4gxnf3NnoIxwNWGvhMBL06jihQw+ULRaM zTRwPFEVTk34naMObUzC5q/z2JKv+OSsN7ShuAXwxjnf+mp9pHdVpj/9mS7eJkM5H7 7xNrrweWNgZVSXSUcL88IJCYe/WKe5jCbGbmU+PMQy8hyOYpBjl2FXDyF9t9slRz/z b+Ty4onGKF0l9jRh3d4RGHUMUf/w0ndkE1lpO017vTOYQTPLfKA3Ab7CwDdg6Ol2Y2 LiLk1qgp55asAgGneg7VEzOFtcoyammYUQZgQg9Khq2B+qA+aoLVSJsjVHDobYLpuI awNGgV9ww6yzw== Date: Thu, 11 Mar 2021 12:38:48 -0800 From: Jakub Kicinski To: Jiapeng Chong Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] netdevsim: fib: Remove redundant code Message-ID: <20210311123848.0af494b0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1615446661-67765-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1615446661-67765-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Mar 2021 15:11:01 +0800 Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return > "0" on line 889. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Reviewed-by: Jakub Kicinski