Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ac6955443a4aa5d0a72e6f2bf15c494f36b78f5c.camel@kernel.org>
Subject: Re: [PATCH] net/mlx5e: include net/nexthop.h where needed
From:   Saeed Mahameed <saeed@kernel.org>
To:     Roi Dayan <roid@nvidia.com>, Arnd Bergmann <arnd@kernel.org>,
        Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Dmytro Linkin <dlinkin@nvidia.com>,
        Vlad Buslov <vladbu@nvidia.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 11 Mar 2021 14:48:23 -0800
In-Reply-To: <5fd5e630-0db2-f83b-63c8-265c4ac372e8@nvidia.com>
References: <20210308153143.2392122-1-arnd@kernel.org>
         <5fd5e630-0db2-f83b-63c8-265c4ac372e8@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-03-08 at 20:23 +0200, Roi Dayan wrote:
> 
> 
> On 2021-03-08 5:31 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > error: implicit declaration of function 'fib_info_nh' [-Werror,-
> > Wimplicit-function-declaration]
> >          fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;
> >                    ^
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > note: did you mean 'fib_info_put'?
> > include/net/ip_fib.h:529:20: note: 'fib_info_put' declared here
> > static inline void fib_info_put(struct fib_info *fi)
> >                     ^
> > 
> > Fixes: 8914add2c9e5 ("net/mlx5e: Handle FIB events to update tunnel
> > endpoint device")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >   drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > index 6a116335bb21..32d06fe94acc 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > @@ -2,6 +2,7 @@
> >   /* Copyright (c) 2021 Mellanox Technologies. */
> >   
> >   #include <net/fib_notifier.h>
> > +#include <net/nexthop.h>
> >   #include "tc_tun_encap.h"
> >   #include "en_tc.h"
> >   #include "tc_tun.h"
> > 
> 
> Hi,
> 
> I see internally we have a pending commit from Vlad fixing this
> already,
> with few more fixes. "net/mlx5e: Add missing include"
> 
> I'll check why it's being held.

Just submitted to net-next. 
Thanks!