Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965312AbWJCJDN (ORCPT ); Tue, 3 Oct 2006 05:03:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932565AbWJCJDN (ORCPT ); Tue, 3 Oct 2006 05:03:13 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:27023 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932563AbWJCJDM (ORCPT ); Tue, 3 Oct 2006 05:03:12 -0400 Subject: Re: [PATCH] IPC namespace core From: David Woodhouse To: Linux Kernel Mailing List Cc: Kirill Korotaev , Pavel Emelianov , Cedric Le Goater , "Eric W. Biederman" , Andrew Morton In-Reply-To: <200610021601.k92G13mT003934@hera.kernel.org> References: <200610021601.k92G13mT003934@hera.kernel.org> Content-Type: text/plain Date: Tue, 03 Oct 2006 10:02:54 +0100 Message-Id: <1159866174.3438.66.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0 (2.8.0-6.fc6.dwmw2.1) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 57 On Mon, 2006-10-02 at 16:01 +0000, Linux Kernel Mailing List wrote: > commit 25b21cb2f6d69b0475b134e0a3e8e269137270fa > tree cd9c3966408c0ca5903249437c35ff35961de544 > parent c0b2fc316599d6cd875b6b8cafa67f03b9512b4d > author Kirill Korotaev 1159780699 -0700 > committer Linus Torvalds 1159801042 -0700 > > [PATCH] IPC namespace core > > This patch set allows to unshare IPCs and have a private set of IPC objects > (sem, shm, msg) inside namespace. Basically, it is another building block of > containers functionality. > > This patch implements core IPC namespace changes: > - ipc_namespace structure > - new config option CONFIG_IPC_NS > - adds CLONE_NEWIPC flag > - unshare support > > [clg@fr.ibm.com: small fix for unshare of ipc namespace] > [akpm@osdl.org: build fix] > Signed-off-by: Pavel Emelianov > Signed-off-by: Kirill Korotaev > Signed-off-by: Cedric Le Goater > Cc: "Eric W. Biederman" > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > --- a/include/linux/ipc.h > +++ b/include/linux/ipc.h > @@ -2,6 +2,7 @@ #ifndef _LINUX_IPC_H > #define _LINUX_IPC_H > > #include > +#include > > #define IPC_PRIVATE ((__kernel_key_t) 0) > You need to move the #include down the file by about 50 lines so it lands inside the existing #ifdef __KERNEL__. All those signed-off-bys and _none_ of you managed to notice that doesn't exist in the headers we export to userspace, despite the fact that just running 'make headers_check' would have shouted at you about it? Bad hacker. No biscuit. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/