Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     David Howells <dhowells@redhat.com>
Cc:     David Woodhouse <dwmw2@infradead.org>, keyrings@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: 'make O=' indigestion with module signing
In-Reply-To: <1486567.1615464259@warthog.procyon.org.uk>
References: <109018.1615463088@turing-police> <91190.1615444370@turing-police> <972381.1615459754@warthog.procyon.org.uk>
 <1486567.1615464259@warthog.procyon.org.uk>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1615510534_20296P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 11 Mar 2021 19:55:34 -0500
Message-ID: <134696.1615510534@turing-police>
Precedence: bulk

--==_Exmh_1615510534_20296P
Content-Type: text/plain; charset=us-ascii

On Thu, 11 Mar 2021 12:04:19 +0000, David Howells said:

> 	EXTRACT_CERTS   /usr/src/linux-next/"certs/signing_key.pem"
>
> but I don't know why.  There are some odd quotes in your line also which may
> be related to the problem.  The relevant config line looks the same:
>
> 	CONFIG_MODULE_SIG_KEY="certs/signing_key.pem"

Aha.  I figured it out.

If you have a *totally* clean source tree, 'make -O' works for all users.
If you have in the past done a build in the tree, and then done a 'make mrproper'
to clean it out so 'make -O' doesn't complain, it fails because it
finds an *old* certs/signing_key.pem in /usr/src/linux-next and tries to
put the new generated files in the same directory.

So the root cause was: 'make mrproper doesn't clean certs/' out enough,
and this chunk of certs/Makefile

# If CONFIG_MODULE_SIG_KEY isn't a PKCS#11 URI, depend on it
ifeq ($(patsubst pkcs11:%,%,$(firstword $(MODULE_SIG_KEY_FILENAME))),$(firstword $(MODULE_SIG_KEY_FILENAME)))
X509_DEP := $(MODULE_SIG_KEY_SRCPREFIX)$(MODULE_SIG_KEY_FILENAME)
endif

MODULE_SIG_KEY_SRCPREFIX was where my /usr/src/linux-next was coming from...

I admit not being sure how (or if) this should be fixed


--==_Exmh_1615510534_20296P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYEq8BQdmEQWDXROgAQKRsQ//QSElUxJzHZdEgOtQv8I7u83Unzhk7zf4
6m4Oz5J40dYCv38GNPCqW3Pq8Gu2ebxjGsjfuOeqG8lZRnAnp4WXgrkrk++uYEef
BgdqtP07VF0c1/11YjDtpheoa5X90IFCM+/MNpW6NtgznsATvu8BXtKp4BaU0ZYk
7rFk7hSV5FNFmcO7djPfZIdRrnwVCWm976PyL+hvb6bsMdVQhPr0+BEe1d/3Sthk
oTtFpHK7NpFA6vpyegiCccpKplUfTyo//PWgnFX1nbiw0rYL9TuGAWsEjqD0ZYTP
iGlbZVyC+PJGIWj/NRYko9OegbPuLlDZEvM6qtB0CRmvIagHWi8ZLnFEr74FensE
d6DikoR6rsktqGFV8AwQT2LwOzxOuI/vQKK7Ku38aPKDPz2NuxGr10ULSK/sVPkg
tN3sVqOJs4UpX2PIiGNIEe/TAxM6X9H3U16MpkCcnqxayXCRvM4uKO/U4Qp0zxz9
w6jhG81RHLjUcjZWahwZJaBLbSAlVzJlD/WzjpGTorye65/OHByOHjB+ao2dZDEz
I5bj/I3EQtxnNOUodmF/i24lMqufqW4usth0wn8D8zxQC1YeN6SbJvBsn25wJANF
6w3N2BXp25uTb8gb70UJ2XAYrE4J0cZxipJaI6y5z2/MmyJqgtK7p+iD0AfvTGv3
Qk/MmHbwdNU=
=aW+D
-----END PGP SIGNATURE-----

--==_Exmh_1615510534_20296P--