Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp917826pxf; Thu, 11 Mar 2021 19:28:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzI/wVh2erCUjJnvPJKOwQeFq3iRkRoDurSOOgz4OPo+u7tAj/mi0qxUGbRWiDvykCsM1h X-Received: by 2002:a50:ee95:: with SMTP id f21mr1808564edr.130.1615519715377; Thu, 11 Mar 2021 19:28:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615519715; cv=none; d=google.com; s=arc-20160816; b=zzPV9yppOpy+V2+704S3fzBG+j+HyOaXD3YTH+cskkVe6zjX5Y2RF+HiV6Wafxbc/O IWW6BkzwsU6OfD+t2n1KZvo2L7qWPvHqW+JByCsDDJDdYU3+BgX9XWfIyMSyroqonc82 j6U6a9XvefBbHayHH1c+XxWprr1/YIxqyJPlyj7N0awfx870SK1cCVWFqV9gEaeAOsPS XUAE2DxRxx5bvT3hKMXsnhTEPm/JR4NVl+M5pWUpiWy+FQ+1eQo6koK91E0+PofGHKvH HMUALxgf5QcYdl63Ci+MWraGwwMcDuJUyTekeoLSq6IOPrGnTUlLcAICpg/1AZEYTu9y Qi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=SkHLh7wNcQ20jzApfwUoY8AVC7vMCj3rCWRAxwIvGtxG6ST6fHtWjKY/tbzz/yeW9u GEpPu8tzh4wFVsFGBNjplN1e8I+t3C9EbJeS6yBKoViLfR7I10ESmGzgn2JS30FlERKj B1gBz6OsEY+Cz02j0/PcioQMoy6poLYVs1rltqxjwBYdjoirwlPfvSYl5+Y5UUrNMd51 Tu79sF3sSLc3AAUeHEF6iZ127efFpz/cA3XichG/YUgPf0DOfpzg4Q+8Y/8fRS68tfnE znaDx+n+u0IzcUXJhf9zTTujC3accwERQGgCt1lHDzgzUTXwsIvHa/PQ8b+kiS3daTLc fofA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=uhDaAHWN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si2940906eji.445.2021.03.11.19.28.12; Thu, 11 Mar 2021 19:28:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=uhDaAHWN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbhCLD0s (ORCPT + 99 others); Thu, 11 Mar 2021 22:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbhCLD0o (ORCPT ); Thu, 11 Mar 2021 22:26:44 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 500EFC061574 for ; Thu, 11 Mar 2021 19:26:44 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id 18so43363605lff.6 for ; Thu, 11 Mar 2021 19:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=uhDaAHWNhpGodMLTIvN6LLx6pBhfH5Zb9oWCNThrJfA0oF1j/GfZJUJpbCXkeR2am2 1G/QJF7dC1izF5DhNn4vSvNM03Tl1DNt3EXw2JihNbCKmk2uQ6JrFy2AvFpbYHBH57kd 35DVw0c5ZmdUZjgpckrDA4sxUiAm5/IjTNcJyT6Luw/YII5Mxf6fUO4T2W2sNEo28UY6 OJ4Hvtt3gvX6tZQCYDvVTVq4a8juiXXSxbn/3AtBZW406WiV+AFe5rWFJUTeDTtTfLuT +Un5pyNWE34YALBPoSWXuOp3E+KyFsjNFG1ZfPyswpi94NGtF7C0Xi+1r7F94PsMr+Jt 1ERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=gHdvCoOTKwjQMzDdSarYiJm8+cp+DYzjz1MIcRp8dBvtxsJJI5FCVtKz8Vn4+qT4OO DHI0DtOneTCjxrc1A7a0qIxamVqxh88ZPBHPOQNtVivpiMhiTRaSTff1tX610KJmdTdV 0AAYeJqarhAOafTGd72Brx5nFoCs7UdVnAuA7FgXZmnvHWC/mCpripzmKnZbZpksLEoJ o3kP/pmOKEmCK+lvrvVDckLVlgmTV3SHzh+k+X5rLMUWKPQ02wV2PcUfEGPHi1lV/srz WIG82/6DjhbfbFJCQUtQUCGvSeXRYOtmk7wFP2Gw74eS/xIWZX5zRMRXg1GzB0HCPCop d8oA== X-Gm-Message-State: AOAM533sdH5up9ZthZneqQZRe7qokNYVE0lGVS7Hk3w91Qtm31ImyFxr EGmj1+dxFA/+TBQEfJqth9eZRivOE8xpCQ6Digt4sA== X-Received: by 2002:a05:6512:39c9:: with SMTP id k9mr3942270lfu.432.1615519602400; Thu, 11 Mar 2021 19:26:42 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-5-songmuchun@bytedance.com> In-Reply-To: <20210309100717.253-5-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 11 Mar 2021 19:26:30 -0800 Message-ID: Subject: Re: [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > The page only can be marked as kmem when CONFIG_MEMCG_KMEM is enabled. > So move PageMemcgKmem() to the scope of the CONFIG_MEMCG_KMEM. > > As a bonus, on !CONFIG_MEMCG_KMEM build some code can be compiled out. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt