Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hermes Zhang <Hermes.Zhang@axis.com>
To:     Marek Behun <marek.behun@nic.cz>
CC:     Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
        kernel <kernel@axis.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: RE: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver
Thread-Topic: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver
Thread-Index: AQHXFnc53ECqmB4gek68ETSLZV586Kp+22cAgAAAc4CAANwtQA==
Date:   Fri, 12 Mar 2021 04:48:52 +0000
Message-ID: <161920e0746e4c0daff7f83163b71677@XBOX03.axis.com>
References: <20210311130408.10820-1-chenhui.zhang@axis.com>
        <20210311163814.74c1885f@nic.cz> <20210311163951.0046fb5c@nic.cz>
In-Reply-To: <20210311163951.0046fb5c@nic.cz>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

>=20
> Sorry, leds-regulator has only a binary state LED.
>=20
> Maybe you could extend leds-regulator to be able to use all regulator sta=
tes?
>=20
> Or you can extend leds-gpio driver to support N states via log N gpios,
> instead of adding new driver.

It seems a good idea to extend leds-gpio, so in my case, I should have such=
 dts:

 63         leds {
 64                 compatible =3D "gpio-leds";
 65=20
 66                 recording_front {
 67                         label =3D "recording_front:red";
 68                         gpios =3D <&gpio 130 GPIO_ACTIVE_HIGH>, <&gpio =
129 GPIO_ACTIVE_HIGH>;
 69                         default-state =3D "off";
 70                 };
 71         };

For my case, two leds is enough, but it sill easy to extend the support num=
ber bigger than two. And the length of gpios array is not fixed, so it coul=
d compatible with exist "gpio-leds" dts, right?=20

If this idea work, should I create a new commit or still in this track (V2)=
?

Best Regards,
Hermes=20

>=20
> Marek