Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1066919pxf; Fri, 12 Mar 2021 00:40:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJzH8QLwGfOpgV/lpK8eaS1kT9viAVdjHgQoPAk1UOVRSNn+qOfU4ZyHSYEHpl09IRNipqrE X-Received: by 2002:a17:906:3c50:: with SMTP id i16mr7512089ejg.175.1615538455830; Fri, 12 Mar 2021 00:40:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615538455; cv=none; d=google.com; s=arc-20160816; b=KFix7TyYKWG/ppU9aPh6B2q5nwYu7rqBQtYJCP1pjlA2a/Ctr6zc/1LO63wVqasO7W AaHaudTshfEDKkgYU9C7cmlQv88go/3dNVAgDHgq0omwJf2GKE2ABxn+ZDxN693UzfLN ou1IAgFolGnMSc79P/hHkYuo7qPpl8pwZ5M2ViXujTaP8grHRTIsjJ/QUMan3260gXtI ezNhbzXXgR2rIsAab1Lwl6j5WHlikWFQzDPc2jmN6y0tSu36SBuQhDmlnyoE5Eb4cE+J d2wM7oV3x7LLZPiBOh2EwQ5xlqWpGGzOxecRvEwaWByxeJxQ9Uj6dtr3Cqivqfg44CUW kWhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=O2NDCYziiJyO4krJrnofmBGvIgA/3b/5zn8RUIs9lXs=; b=OGax5oZzfO6hgzjgUV3MmoiUEfgMNbBrEnPi4/VwWT5KrbmMxsAwKyzo8LvmaZMhMc 6t1I1rRU2LIi2y3msGcK9t6AG5Yetw2EYPdrEhQ5a2Twb41UMEjyJ1+XkZ7qpyw5aiz+ N6/IhIrPVjhKbEIhQTBtnN2yCvwuZH4cujEZ0SuXhI4YZopRyxBYUAK59urva3Lvfu66 UWCJKiiLPlUapoFkoKb9Sye+RAqnrN507YdtDV+TyAlRjbsoNymC6bGv7zzZ3GlX7vpu MknZDAAStiIDVlAzzHzBd0gF/LFYGJt5bKq23f0j6n2edPK11zyOygY0NHUeRAePtNKc RDfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si3686819ejy.707.2021.03.12.00.40.32; Fri, 12 Mar 2021 00:40:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232326AbhCLIjG (ORCPT + 99 others); Fri, 12 Mar 2021 03:39:06 -0500 Received: from mail-m118208.qiye.163.com ([115.236.118.208]:48872 "EHLO mail-m118208.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232321AbhCLIjF (ORCPT ); Fri, 12 Mar 2021 03:39:05 -0500 X-Greylist: delayed 590 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Mar 2021 03:39:04 EST Received: from wanjb-virtual-machine.localdomain (unknown [36.152.145.182]) by mail-m118208.qiye.163.com (Hmail) with ESMTPA id A6B01E03A8; Fri, 12 Mar 2021 16:29:11 +0800 (CST) From: Wan Jiabing To: Russell King , Wan Jiabing , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@vivo.com, kael_w@yeah.net Subject: [PATCH] arm: plat-pxa: delete redundant printing of the error Date: Fri, 12 Mar 2021 16:28:40 +0800 Message-Id: <20210312082841.37779-1-wanjiabing@vivo.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZHU4dGEhMHx1NHR0YVkpNSk5OSExMTkpCSUpVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKSkNITFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ORg6Nxw4KD8NAwESFSoMGg4j TykaCzlVSlVKTUpOTkhMTE5JSkNCVTMWGhIXVQwaFRESGhkSFRw7DRINFFUYFBZFWVdZEgtZQVlI TVVKTklVSk9OVUpDSVlXWQgBWUFKTkJJNwY+ X-HM-Tid: 0a78258dc7262c17kusna6b01e03a8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq() has already checked and printed the error, the printing here is not necessary at all. Signed-off-by: Wan Jiabing --- arch/arm/plat-pxa/ssp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 563440315acd..9e77b3392c1e 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } if (dev->of_node) { const struct of_device_id *id = -- 2.25.1