Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 12 Mar 2021 10:49:31 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Daniel Baluta <daniel.baluta@gmail.com>
Cc:     Daniel Baluta <daniel.baluta@oss.nxp.com>,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "S.j. Wang" <shengjiu.wang@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH] ASoC: core: Don't set platform name when of_node is set
Message-ID: <20210312104931.GA5348@sirena.org.uk>
References: <20210309082328.38388-1-daniel.baluta@oss.nxp.com>
 <20210309153455.GB4878@sirena.org.uk>
 <CAEnQRZB_VgsEPYgxtWQWUgs2+noRt1AMMHf2crJ_9Hg7s7NJ0Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/"
Content-Disposition: inline
In-Reply-To: <CAEnQRZB_VgsEPYgxtWQWUgs2+noRt1AMMHf2crJ_9Hg7s7NJ0Q@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote:
> On Tue, Mar 9, 2021 at 5:38 PM Mark Brown <broonie@kernel.org> wrote:

> > > +                     if (!dai_link->platforms->of_node)
> > > +                             dai_link->platforms->name = component->name;

> > Why would we prefer the node name over something explicitly configured?

> Not sure I follow your question. I think the difference stands in the
> way we treat OF vs non-OF platforms.

If an explicit name has been provided why would we override it with an
autogenerated one?

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBLRzoACgkQJNaLcl1U
h9DHLgf/dCrl7QiN+jfF0cGbC1JdfYVq4HAVtswUrQEnPISDtyOBMpD2WjMCmM8j
mAv2nD3wC8p0mFgDWKn/KEcmsj7KXiFO3sD63kQsiolJrk5rTX5NAtvHeVuXxZ8+
yQVlP6G8CVpAcjk6CcKpEtWp+cT1H2uDXq4XyGzILCfzlPNqfRRLU9wZesvB3mtS
mpd1v/6aN6iXcbKYQWzD4jR70WsTAJw3IFcUtJCGejos6hHYSsrdhD8rPuT59WY7
T/lXXFVZM7+nwbd5AeL/CqlldmKcS40nfRevG9GbIkpm37kFdWvk0g1shf83owPB
6HOiE4Gctdl3DTxDYJgLfMNNXrZF/w==
=pOj0
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--